Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added registration block time and slot number to the snapshot_tool output #481

Closed

Conversation

FelipeRosa
Copy link
Contributor

Description

Please include a summary of the changes and the related issue.
Please also include relevant motivation and context.
List any dependencies that are required for this change.

Fixes # (issue) if applicable

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration: if applicable

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

List of new dependecies: if applicable

Provide a list of newly added dependencies in this PR, with the description of what are they doing and why do we need them.

  • Crate A: description
  • Crate B: description

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@FelipeRosa FelipeRosa self-assigned this Jul 24, 2023
@FelipeRosa FelipeRosa force-pushed the add-registration-blocktime-to-snapshot-tool-output branch from 5aa9345 to 25aa133 Compare July 24, 2023 19:55
@FelipeRosa FelipeRosa added the do not review yet Do not review yet label Jul 24, 2023
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all look OK.

@github-actions github-actions bot deleted the add-registration-blocktime-to-snapshot-tool-output branch September 11, 2023 06:06
@FelipeRosa FelipeRosa closed this Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not review yet Do not review yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants