Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Better error messages in ideascale importer | NPG-7753 #484

Merged
merged 3 commits into from
Jul 26, 2023
Merged

chore: Better error messages in ideascale importer | NPG-7753 #484

merged 3 commits into from
Jul 26, 2023

Conversation

FelipeRosa
Copy link
Contributor

@FelipeRosa FelipeRosa commented Jul 25, 2023 •
edited
Loading

Description

  • Makes Ideascale importer log an error instead of throwing an exception.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Ran the ideascale importer with a campaign that has no tagline.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@FelipeRosa FelipeRosa self-assigned this Jul 25, 2023
Mr-Leshiy
Mr-Leshiy previously approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FelipeRosa FelipeRosa force-pushed the NPG-7753-ideascale-importer-throws-an-exception-when-the-campain-is-missing-the-tagline branch from 5954442 to 0e465fc Compare July 25, 2023 15:19
@FelipeRosa FelipeRosa changed the title chore: Better error messages in ideascale importer chore: Better error messages in ideascale importer | NPG-7753 Jul 25, 2023
@minikin minikin enabled auto-merge (squash) July 26, 2023 12:35
@minikin minikin added the review me PR is ready for review label Jul 26, 2023
@minikin minikin merged commit a131572 into main Jul 26, 2023
25 checks passed
@minikin minikin deleted the NPG-7753-ideascale-importer-throws-an-exception-when-the-campain-is-missing-the-tagline branch July 26, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mr-Leshiy Mr-Leshiy Mr-Leshiy approved these changes

Assignees

@FelipeRosa FelipeRosa

Labels
review me PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FelipeRosa @Mr-Leshiy @minikin