Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow skipping insertion of historical/test data in migrations … #485

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

jmgilman
Copy link
Collaborator

Currently, this is being controlled when the container is built. If a specific flag is passed, the data will either be present or absent when the container is built, thus causing the for loop to execute or not. This isn't really ideal, since we prefer to have the container ship with everything and then configure what gets inserted at runtime.

I've added environment variables to control this at runtime. I have not modified the Earthfile to change the previous logic because I'm not sure if it's actively being used anywhere.

Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevenj stevenj merged commit 2a72a38 into main Jul 26, 2023
23 of 25 checks passed
@stevenj stevenj deleted the migrations-allow-skip-inserting branch July 26, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants