Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update preprod snapshot times | NPG-000 #721

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

emiride
Copy link
Contributor

@emiride emiride commented Nov 6, 2024

Description

Please include a summary of the changes and the related issue.
Please also include relevant motivation and context.
List any dependencies that are required for this change.

Fixes # (issue) if applicable

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration: if applicable

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

List of new dependencies: if applicable

Provide a list of newly added dependencies in this PR, with the description of what are they doing and why do we need them.

  • Crate A: description
  • Crate B: description

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@emiride emiride self-assigned this Nov 6, 2024
@emiride emiride requested a review from kukkok3 November 6, 2024 12:23
@emiride emiride changed the title Practicing dryrun preprod NPG-000 Practicing dryrun preprod Nov 6, 2024
@emiride emiride changed the title NPG-000 Practicing dryrun preprod Practicing dryrun preprod | NPG-000 Nov 6, 2024
@emiride emiride changed the title Practicing dryrun preprod | NPG-000 chore: practicing dryrun preprod | NPG-000 Nov 6, 2024
Copy link
Contributor

@kukkok3 kukkok3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kukkok3 kukkok3 enabled auto-merge (squash) November 6, 2024 12:30
@kukkok3 kukkok3 changed the title chore: practicing dryrun preprod | NPG-000 chore: Practicing dryrun preprod | NPG-000 Nov 6, 2024
@kukkok3 kukkok3 changed the title chore: Practicing dryrun preprod | NPG-000 chore: Update preprod snapshot times | NPG-000 Nov 6, 2024
@kukkok3 kukkok3 merged commit 328a025 into main Nov 6, 2024
58 of 65 checks passed
@kukkok3 kukkok3 deleted the dryrun-testing-emir branch November 6, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants