Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DDW-977] Add sync-tolerance parameter for jormungandr wallet #1666

Merged
merged 12 commits into from
Nov 12, 2019
Merged

[DDW-977] Add sync-tolerance parameter for jormungandr wallet #1666

merged 12 commits into from
Nov 12, 2019

Conversation

disassembler
Copy link
Contributor

@disassembler disassembler commented Nov 10, 2019 •
edited by nikolaglumac
Loading

This PR adds sync-tolerance parameter and bumps cardano-wallet version.

Testing Checklist

Review Checklist

Basics

  • PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • Automated tests: All acceptance and unit tests are passing (yarn test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
  • There are no flow errors or warnings (yarn flow:test)
  • There are no lint errors or warnings (yarn lint)
  • There are no prettier errors or warnings (yarn prettier:check)
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Merge the PR
  • Delete the source branch
  • Move the ticket to done column on the YouTrack board
  • Update Slack QA thread by marking it with a green checkmark

Sam-Jeston
Sam-Jeston suggested changes Nov 11, 2019
View reviewed changes
nix/launcher-config.nix Outdated Show resolved Hide resolved
rvl
rvl reviewed Nov 11, 2019
View reviewed changes
nix/sources.json Outdated Show resolved Hide resolved
@craigem
Copy link

craigem commented Nov 11, 2019

If you can please review this again @rvl @Sam-Jeston.

rvl
rvl approved these changes Nov 11, 2019
View reviewed changes
Copy link
Contributor

@rvl rvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revs look correct, launch args seem like they might work.
I'm downloading the self node windows installer to try now.

@craigem craigem changed the base branch from v2-integration to master November 11, 2019 05:44
@craigem craigem changed the base branch from master to v2-integration November 11, 2019 05:45
@nikolaglumac nikolaglumac assigned disassembler and unassigned craigem Nov 11, 2019
@nikolaglumac nikolaglumac changed the title jormungandr wallet: add sync-tolerance parameter [DDW-977] Add sync-tolerance parameter for jormungandr wallet Nov 11, 2019
nikolaglumac
nikolaglumac approved these changes Nov 11, 2019
View reviewed changes
Copy link
Contributor

@nikolaglumac nikolaglumac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@nikolaglumac
Copy link
Contributor

Before we can merge this one we need at least one approval from our QA team (@alan-mcnicholas @IuliaDolishniak @DmitriiGaico)

cc @disassembler @craigem @rvl @Sam-Jeston

tomislavhoracek
tomislavhoracek suggested changes Nov 12, 2019
View reviewed changes
Copy link
Contributor

@tomislavhoracek tomislavhoracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@disassembler nice job 🚀
I left some comments on the code. Can you please take a look?

source/renderer/app/containers/loading/SystemTimeErrorPage.js Show resolved Hide resolved
source/renderer/app/components/status/DaedalusDiagnostics.js Show resolved Hide resolved
source/renderer/app/api/utils/patchAdaApi.js Show resolved Hide resolved
source/renderer/app/containers/loading/LoadingPage.js Show resolved Hide resolved
source/renderer/app/containers/loading/SystemTimeErrorPage.js Show resolved Hide resolved
tomislavhoracek
tomislavhoracek approved these changes Nov 12, 2019
View reviewed changes
Copy link
Contributor

@tomislavhoracek tomislavhoracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikolaglumac Everything looks good, exceptional work 💯

alan-mcnicholas
alan-mcnicholas approved these changes Nov 12, 2019
View reviewed changes
Copy link

@alan-mcnicholas alan-mcnicholas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing with build 8887 against Nightly I am not seeing any sync issues on Windows, Linux and MacOS over time. Transactions are also sending correctly.

@nikolaglumac nikolaglumac merged commit c35836e into v2-integration Nov 12, 2019
@iohk-bors iohk-bors bot deleted the sync-tolerance branch November 12, 2019 12:53
@nikolaglumac nikolaglumac added release-1.0.0-ITN0 Daedalus Incentivized Testnet - Balance check and removed V2-API ⏳release-vNext labels Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craigem craigem craigem left review comments

@nikolaglumac nikolaglumac nikolaglumac approved these changes

@alan-mcnicholas alan-mcnicholas alan-mcnicholas approved these changes

@tomislavhoracek tomislavhoracek tomislavhoracek approved these changes

@Sam-Jeston Sam-Jeston Sam-Jeston approved these changes

@rvl rvl rvl approved these changes

@DmitriiGaico DmitriiGaico Awaiting requested review from DmitriiGaico

@IuliaDolishniak IuliaDolishniak Awaiting requested review from IuliaDolishniak

@thedanheller thedanheller Awaiting requested review from thedanheller

Assignees

@disassembler disassembler

Labels
chore release-1.0.0-ITN0 Daedalus Incentivized Testnet - Balance check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@disassembler @craigem @nikolaglumac @rvl @Sam-Jeston @tomislavhoracek @alan-mcnicholas