Minimal test suite #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add support for urls with file: schema; both absolute (file:/path) and relative (file:path) paths are supported. - Log curl invocation in case of failure - Rename fetchRemoteAsset to fetchURL - Add verbosity flag - Bump GHC to 9.4.7 - Bump flake inputs
I'd be inclined to create them on the fly, although that's more code.
I definitely think running them in a tmpdir is a good idea, but yeah, having a flag to keep the directory is super useful if things fail. |
michaelpj
approved these changes
Sep 11, 2023
Co-authored-by: Michael Peyton Jones <[email protected]>
- Move sourceUrl to Foliage.Meta.packageVersionSourceToUri
Closed
yvan-sraka
pushed a commit
to yvan-sraka/foliage
that referenced
this pull request
Sep 22, 2023
* Minimal test suite - Add support for urls with file: schema; both absolute (file:/path) and relative (file:path) paths are supported. - Log curl invocation in case of failure - Rename fetchRemoteAsset to fetchURL - Add verbosity flag - Bump GHC to 9.4.7 - Bump flake inputs * Apply suggestions from code review Co-authored-by: Michael Peyton Jones <[email protected]> * Add short option '-v' for '--verbosity' * Whitespace * Add comment explaining why the dot * Rename withFixture to inTemporaryDirectoryWithFixture * Small refactor of PrepareSource * Rename TarballSource to URISource - Move sourceUrl to Foliage.Meta.packageVersionSourceToUri * Simplify inTemporaryDirectoryWithFixture * Document tar and cp flags * Reformat --------- Co-authored-by: Michael Peyton Jones <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #7
Add support for urls with file: schema; both absolute (file:/path) and
relative (file:path) paths are supported.
Log curl invocation in case of failure
Rename fetchRemoteAsset to fetchURL
Add verbosity flag
Bump GHC to 9.4.7
Bump flake inputs
Feedback is welcome.
Some design issues:
tests/fixtures/simple/tarballsalong with their unpacked sources but it's not a great solution.withFixturescreates a temporary directory and symlinks the fixture files. This allows running the tests in parallel but that temporary gets wiped when the test finish. Maybe it's better to keep it around?TODO
Accept a file:// url that points to a cabal file, foliage will make a source distribution from the package in that folder.It's a good idea but there are too many design decision involved. Leaving this for another time.