Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nixpkgs unstable. #1196

Merged
merged 7 commits into from
Aug 17, 2021
Merged

Conversation

shlevy
Copy link
Contributor

@shlevy shlevy commented Aug 10, 2021

Plutus needs NixOS/nixpkgs#127239.

@hamishmack
Copy link
Collaborator

bors try

iohk-bors bot added a commit that referenced this pull request Aug 10, 2021
@hamishmack
Copy link
Collaborator

bors try-

@hamishmack
Copy link
Collaborator

bors try

iohk-bors bot added a commit that referenced this pull request Aug 10, 2021
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 10, 2021

try

Build failed:

@shlevy
Copy link
Contributor Author

shlevy commented Aug 10, 2021

bors try

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 10, 2021

🔒 Permission denied

Existing reviewers: click here to make shlevy a reviewer

@shlevy
Copy link
Contributor Author

shlevy commented Aug 11, 2021

bors try

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 11, 2021

🔒 Permission denied

Existing reviewers: click here to make shlevy a reviewer

@shlevy
Copy link
Contributor Author

shlevy commented Aug 11, 2021

bors try

iohk-bors bot added a commit that referenced this pull request Aug 11, 2021
@shlevy shlevy marked this pull request as draft August 11, 2021 09:27
@shlevy
Copy link
Contributor Author

shlevy commented Aug 11, 2021

Draft until NixOS/nixpkgs#133479 hits nixpkgs-unstable and hydra is happy

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 11, 2021

try

Build failed:

@shlevy
Copy link
Contributor Author

shlevy commented Aug 11, 2021

bors try

iohk-bors bot added a commit that referenced this pull request Aug 11, 2021
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 11, 2021

try

Build failed:

@shlevy
Copy link
Contributor Author

shlevy commented Aug 14, 2021

bors try

iohk-bors bot added a commit that referenced this pull request Aug 14, 2021
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 14, 2021

try

Build failed:

@hamishmack
Copy link
Collaborator

bors try

iohk-bors bot added a commit that referenced this pull request Aug 17, 2021
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 17, 2021

try

Build failed:

@hamishmack
Copy link
Collaborator

bors try

iohk-bors bot added a commit that referenced this pull request Aug 17, 2021
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 17, 2021

try

Build failed:

@hamishmack
Copy link
Collaborator

bors try

iohk-bors bot added a commit that referenced this pull request Aug 17, 2021
@hamishmack
Copy link
Collaborator

bors try-

@hamishmack
Copy link
Collaborator

bors try

iohk-bors bot added a commit that referenced this pull request Aug 17, 2021
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 17, 2021

try

Build failed:

@michaelpj
Copy link
Collaborator

I'm a bit confused about this PR: we can just bump nixpkgs in plutus, we pass in our own rather than using the haskell.nix pin.

@hamishmack
Copy link
Collaborator

bors try-

@hamishmack
Copy link
Collaborator

bors try

iohk-bors bot added a commit that referenced this pull request Aug 17, 2021
@hamishmack
Copy link
Collaborator

I'm a bit confused about this PR: we can just bump nixpkgs in plutus, we pass in our own rather than using the haskell.nix pin.

I was not sure how to do the equivalent of an ifdLevel 1 build on plutus and was worried it would build ghc at eval time. We made a PR to build it here first and it turned up some issues. First with ghc 8.10.5 on windows and once patched it seems we ghc 8.6.5 for windows is broken still. That would not be a problem if we were skipping the combination of nixpkgs-unstable, ghc 8.6.5 and windows. It turns out we have been including that version of GHC incorrectly via stack based tests that use a resolver with that version.

@shlevy
Copy link
Contributor Author

shlevy commented Aug 17, 2021

@michaelpj We already bumped plutus, but would still be good to be able to move this forward as well. Also last I checked on this one of the failures was mingw cross, which may impact our plutus cross efforts.

@michaelpj
Copy link
Collaborator

I was not sure how to do the equivalent of an ifdLevel 1 build on plutus and was worried it would build ghc at eval time. We made a PR to build it here first and it turned up some issues

Ah yes, I remember now. It would be nice to figure out how to do that in downstream projects, but 👍

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 17, 2021

@hamishmack hamishmack marked this pull request as ready for review August 17, 2021 12:41
@hamishmack hamishmack merged commit 8aa77fd into input-output-hk:master Aug 17, 2021
@angerman
Copy link
Collaborator

Just to make this clear what @hamishmack said: nixpkgs-unstabe/ghc-8.6.5 are broken. This is due to the upated mingw in nixpkgs unstable. The required backport patch does not appear to be worth the effort to backport!

@shlevy shlevy deleted the nixpkgs-bump branch August 19, 2021 13:35
booniepepper pushed a commit to booniepepper/haskell.nix that referenced this pull request Feb 4, 2022
* Update nixpkgs unstable.

Plutus needs NixOS/nixpkgs#127239.

* Don't include stack tests that use ghc 8.6.5 when testing ghc 8.10.5

Co-authored-by: Hamish Mackenzie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants