Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cabal-issue-8352-workaround #1671

Merged
merged 3 commits into from
Sep 15, 2022
Merged

Add cabal-issue-8352-workaround #1671

merged 3 commits into from
Sep 15, 2022

Conversation

hamishmack
Copy link
Collaborator

@hamishmack hamishmack commented Sep 15, 2022 •
edited
Loading

I missed a couple of places where we call cabal update and now need the dummy ghc to prevent cabal from complaining.

See haskell/cabal#8352

@hamishmack
Copy link
Collaborator Author

bors try

iohk-bors bot added a commit that referenced this pull request Sep 15, 2022
@iohk-bors
Try #1671:
a8c76f3
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 15, 2022

try

Build failed:

@hamishmack
Copy link
Collaborator Author

bors try-

@hamishmack
Copy link
Collaborator Author

bors try

iohk-bors bot added a commit that referenced this pull request Sep 15, 2022
@iohk-bors
Try #1671:
66aad71
angerman
angerman approved these changes Sep 15, 2022
View reviewed changes
Copy link
Collaborator

@angerman angerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool. I guess at some point we can parameterise the fake GHC with the version. Ideally though, we'll never need it...

@hamishmack
Copy link
Collaborator Author

I guess at some point we can parameterise the fake GHC with the version

I sure hope they fix the bug in cabal before they start requiring a newer version!

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 15, 2022

try

Build succeeded:

@hamishmack hamishmack merged commit a197fd0 into master Sep 15, 2022
@iohk-bors iohk-bors bot deleted the hkm/cabal-3.8-fixes branch September 15, 2022 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angerman angerman angerman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hamishmack @angerman