Fix haskell.nix evaluation with recent nixpkgs
#1859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhess
added a commit
to hackworthltd/primer
that referenced
this pull request
Feb 23, 2023
dhess
added a commit
to hackworthltd/primer
that referenced
this pull request
Feb 23, 2023
Note that the new `haskell.nix` pin necessitates the following additional changes: * We switch temporarily to our own `haskell.nix` fork, as recent versions no longer work with `nixpkgs`'s NixOS test framework. See input-output-hk/haskell.nix#1859. * We include a workaround for input-output-hk/haskell.nix#1857 (which itself is a workaround for input-output-hk/haskell.nix#839). * We no longer need the `hostPkgs` hack to make the NixOS tests build. * We need to bump the NixOS VM disk size, as it's no longer large enough to build the `primer-service` Docker image.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
In our
haskell.nixflake-based project, we're always careful to use thehaskell.nix-providednixpkgs-unstablepin to build our Haskell packages, because we want to take advantage of the IOG binary cache.However, in the same flake, we also want to run some NixOS tests which use our Haskell packages. In recent months,
nixpkgshas made this relatively easy to do (see https://nixos.org/manual/nixos/unstable/index.html#sec-call-nixos-test-outside-nixos). Until recently, we were able to make this work withhaskell.nix'snixpkgs-unstablepin with an ugly hack, but unfortunately, as of the most recentnixpkgs-unstablepin (747927516efcb5e31ba03b7ff32f61f6d47e7d87), our hack no longer works, for a few reasons:overlays/bootstrap.nix(and elsewhere),final.buildPlaformand friends no longer exist.pkgsBuildBuild.systemno longer exists.pkgconfigalias has been removed (now onlypkg-configexists).I'm not suggesting that this PR is merged, as I confess that I don't really understand how
haskell.nixworks at this level of detail, and I was just blindly replacing various attributes with their obvious replacements, so it's possible that I've broken something else. But these changes do allow us now to usenixos-lib.runTest, and don't seem to adversely affect our ability to build our Haskell packages.(I confess I'm a bit confused as to how
haskell.nixbuilds at all with thenixpkgs-unstablepin. I suppose you all are careful not to use that pin to evaluate the project in your CI system?)