Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move to chain-deps #542

Merged
merged 3 commits into from
Jun 19, 2019
Merged

move to chain-deps #542

merged 3 commits into from
Jun 19, 2019

Conversation

vincenthz
Copy link
Member

No description provided.

@vincenthz vincenthz added the technical debt issue to track potential technical dept we are introducing but will need care later. label Jun 19, 2019
mzabaluev
mzabaluev reviewed Jun 19, 2019
View reviewed changes
Copy link
Contributor

@mzabaluev mzabaluev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to also handle missing address on YAML reading to pass the test (and I guess real existing configs), otherwise looks good.

NicolasDP
NicolasDP reviewed Jun 19, 2019
View reviewed changes
jcli/src/jcli_app/block/DOCUMENTED_EXAMPLE.yaml
# - legacy_fund:
# # Legacy Cardano address
# address: 48mDfYyQn21iyEPzCfkATEHTwZBcZJqXhRJezmswfvc6Ne89u1axXsiazmgd7SwT8VbafbVnCvyXhBSMhSkPiCezMkqHC4dmxRahRC86SknFu6JF6hwSg8
# value: 123
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we just remove this since we are not handling this for now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just commented it, since it will be re-added later, but I thought about it too.

NicolasDP
NicolasDP approved these changes Jun 19, 2019
View reviewed changes
Copy link
Contributor

@NicolasDP NicolasDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the doc might have references to the old utxos

@vincenthz
Copy link
Member Author

same reason than the commented line in the yaml file, that will cost to re-add them later ... hopefully this is just temporary removal

@vincenthz vincenthz merged commit 1ad7e8e into master Jun 19, 2019
@vincenthz vincenthz deleted the to-chain-deps branch July 31, 2019 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzabaluev mzabaluev mzabaluev left review comments

@NicolasDP NicolasDP NicolasDP approved these changes

Assignees
No one assigned
Labels
technical debt issue to track potential technical dept we are introducing but will need care later.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vincenthz @mzabaluev @NicolasDP