Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add clock and exclamation mark icons [LW-9231] #61

Merged
merged 1 commit into from
Oct 18, 2024
Merged

feat: add clock and exclamation mark icons [LW-9231] #61

merged 1 commit into from
Oct 18, 2024

Conversation

DominikGuzei
Copy link
Member

This PR just adds two icons required for https://input-output.atlassian.net/browse/LW-9231

@DominikGuzei DominikGuzei added the enhancement New feature or request label Oct 18, 2024
@DominikGuzei DominikGuzei self-assigned this Oct 18, 2024
greatertomi
greatertomi approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@greatertomi greatertomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@DominikGuzei DominikGuzei force-pushed the feat/lw-9231-add-clock-and-exclamation-icons branch from ccadcbb to ba04dd5 Compare October 18, 2024 12:12
przemyslaw-wlodek
przemyslaw-wlodek approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@przemyslaw-wlodek przemyslaw-wlodek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thank you 😄 It would be great if you could remove width / height and leave just a viewBox.

@DominikGuzei DominikGuzei force-pushed the feat/lw-9231-add-clock-and-exclamation-icons branch from ba04dd5 to 37e5b2b Compare October 18, 2024 12:21
@DominikGuzei
Copy link
Member Author

@przemyslaw-wlodek done 👍

@DominikGuzei DominikGuzei force-pushed the feat/lw-9231-add-clock-and-exclamation-icons branch from 37e5b2b to a66cff7 Compare October 18, 2024 12:30
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@DominikGuzei DominikGuzei merged commit c8b53eb into main Oct 18, 2024
3 checks passed
@DominikGuzei DominikGuzei deleted the feat/lw-9231-add-clock-and-exclamation-icons branch October 18, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greatertomi greatertomi greatertomi approved these changes

@przemyslaw-wlodek przemyslaw-wlodek przemyslaw-wlodek approved these changes

Assignees

@DominikGuzei DominikGuzei

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DominikGuzei @przemyslaw-wlodek @greatertomi