Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config.nix to not need the lets #2

Closed

Conversation

Ericson2314
Copy link

This doesn't preserve hashes: The ghc used to build Setup.hs is now the normal ghcHEAD. If you want to make that yours too again, make the ghcHEAD override unconditional.

@angerman
Copy link
Collaborator

angerman commented Mar 9, 2018

This doesn't build for me. Due to parsec only being shipped with recent GHCs. I'll see if I can amend it. As I mentioned in NixOS/nixpkgs#36200, I wonder if I can just inject a custom GHC, without having to override the ghcHEAD.

@Ericson2314
Copy link
Author

Yeah sorry. I should have added I just instantiated it. It is plenty possible to not override ghcHEAD. I'll change this to do that.

@Ericson2314
Copy link
Author

@angerman Ahhh. Yeah the issue with your old one is config gets applied to the build != host == target and build == host != target package set, but not the build == host == target package set.

But that's fine in this case as there's no reason to use ghcAngerman to build Setup.hs, as that will just make your debug cycle twice as long.

@Ericson2314
Copy link
Author

@angerman Oh I see, the conventional ghcHEAD won't build Cabal, even if I add an explicit parsec dep. Wanna bump nixpkgs / bump ghcHEAD in nixpkgs so that we can dodge that? I can add the increase override support too, of course.

@angerman
Copy link
Collaborator

@Ericson2314 well, building HEAD with HEAD, is actually a common use case for cross compiler, if you want to get anywhere near abi stability.

For the "using" head situation, you mostly want

some ghc binary to bootstrap HEAD (stage2), which you use to build your Cross Compiler (stage1). As that point all your ghcs (cross and non-cross) are the same version, and have been built against the same packages, and use the identical code gen.

@Ericson2314
Copy link
Author

That's fair; good to fix the override issue in any event. I'll aim do that later today.

@angerman angerman changed the base branch from master to build-more March 22, 2018 06:43
@Ericson2314 Ericson2314 changed the base branch from build-more to master March 22, 2018 13:40
@Ericson2314 Ericson2314 changed the base branch from master to build-more March 22, 2018 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants