-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conformance tests and soundness proof in Agda #170
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get delta parameter from the network Co-authored-by: Yves Hauser <[email protected]>
Implemented `chainWeight` in Agda and reorganized packages and build
Implemented postulates needed for quickcheck model
* Unification in `newVote-preconditions` did not work anymore and providing refl as prf was failing * Splitting up the voting rules might be helpful in the soundness proof
The conformance test was failing for 2 reasons: 1. The maximumBy function was wrong, it actually was minimumBy 2. The preferred chain selection logic did not select the same chain in case of weight ties
ghost
mentioned this pull request
Jul 4, 2024
Closed
ghost
approved these changes
Jul 4, 2024
It's all green, I suggest we merge this and create another branch for the soundness proof completion, WDYT @yveshauser ? |
yveshauser
approved these changes
Jul 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving for now - soundness proof is outstanding
ghost
deleted the
yveshauser/peras-conformance
branch
July 4, 2024 16:29
3 tasks
ghost
pushed a commit
that referenced
this pull request
Jul 5, 2024
This change provides an Agda-based conformance test suite for the voting logic of Peras protocol, and a skeleton for the soundness proof. Some details about the changes: * Use of IOG Agda prelude * Update test model to align with spec (T = 0, Δ = 0) * Aligned versions of `agda` and `agda2hs` in nix. * Compiles under `agda2hs`. * Moved `peras-hs` into `peras-simulation`. * Implemented crypto and various helper functions in Agda * Relocated conformance-related and prototype modules * Added property-based test for prototype against Agda spec. * Split up the voting rules which might be helpful in the soundness proof Note the conformance test was initially failing for 2 reasons: 1. The maximumBy function was wrong, it actually was minimumBy 2. The preferred chain selection logic did not select the same chain in case of weight ties --------- Co-authored-by: Ulf Norell <[email protected]> Co-authored-by: Yves Hauser <[email protected]> Co-authored-by: Brian W. Bush <[email protected]>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.