Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --end flag for add command #307

Closed
wants to merge 1 commit into from

Conversation

michaelPotter
Copy link

Instead of specifying an event duration during creation, it can be
useful to give an event end time. This commit adds a --end flag that can
be used as an alternative to the --duration flag.

The --end flag takes a date string similar to the --when flag.

Given both a --end flag and a --duration flag, the duration value
will take precedence. Given neither flag, duration will be asked for
in interactive mode.

Instead of specifying an event duration during creation, it can be
useful to give an event end time. This commit adds a --end flag that can
be used as an alternative to the --duration flag.

The --end flag takes a date string similar to the --when flag.

Given both a --end flag and a --duration flag, the duration value
will take precedence. Given neither flag, duration will be asked for
in interactive mode.
@jcrowgey
Copy link
Collaborator

I like this idea, can you rebase your changes upon current master?

@maxpereira
Copy link

this is a really excellent idea, any update on this?

@jcrowgey
Copy link
Collaborator

I think the idea here is sound, but we'd need to rebase upon current master in order to merge. Ideally, we would like to see some sort of unit tests added. @maxpereira if @michaelPotter isn't working on this anymore, is this something you could pick up to get it across the finish line?

@dbarnett
Copy link
Collaborator

I put together a version on top of current master in #708. Closing this stale PR in favor of that one.

Thanks!

@dbarnett dbarnett closed this Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants