Fix deprecation warnings #1746
Fix deprecation warnings #1746
Conversation
There was a problem hiding this comment.
This is an external library, are we updating from here? https://github.com/woocommerce/action-scheduler/blob/trunk/classes/schema/ActionScheduler_StoreSchema.php
There was a problem hiding this comment.
nope sorry I didn't noticed that, I gonna check for upgrading it instead of editing it. Do I just need to upgrade the package and replace the entire library manually correct? I'm not seeing a composer here to manage the dependency, if I'm not wrong.
There was a problem hiding this comment.
Correct, if I remember correctly, it is just a drop-in.
There was a problem hiding this comment.
moved into a new commit which upgrade the library: 282e985
| @@ -10,12 +10,12 @@ | |||
| * file that was distributed with this source code. | |||
| */ | |||
|
|
|||
| namespace Wordlift_Modules_Common_Composer\Autoload; | |||
| namespace Composer\Autoload; | |||
There was a problem hiding this comment.
We need a custom scoped namespace or it can clash with other libraries.
|
|
||
| /** | ||
| * ClassLoader implements a PSR-0, PSR-4 and classmap class loader. | ||
| * | ||
| * $loader = new \Wordlift_Modules_Common_Composer\Autoload\ClassLoader(); | ||
| * $loader = new \Composer\Autoload\ClassLoader(); |
There was a problem hiding this comment.
We need a custom scoped namespace or it can clash with other libraries.
| @@ -8,13 +8,13 @@ class ComposerAutoloaderInit8bd2b6d4ccd6b50e0809e5ba62169420 | |||
|
|
|||
| public static function loadClassLoader($class) | |||
| { | |||
| if ('Wordlift_Modules_Common_Composer\Autoload\ClassLoader' === $class) { | |||
| if ('Composer\Autoload\ClassLoader' === $class) { | |||
There was a problem hiding this comment.
We need a custom scoped namespace or it can clash with other libraries.
| require __DIR__ . '/ClassLoader.php'; | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * @return \Wordlift_Modules_Common_Composer\Autoload\ClassLoader | ||
| * @return \Composer\Autoload\ClassLoader |
There was a problem hiding this comment.
We need a custom scoped namespace or it can clash with other libraries.
| @@ -23,11 +23,11 @@ public static function getLoader() | |||
| } | |||
|
|
|||
| spl_autoload_register(array('ComposerAutoloaderInit8bd2b6d4ccd6b50e0809e5ba62169420', 'loadClassLoader'), true, true); | |||
| self::$loader = $loader = new \Wordlift_Modules_Common_Composer\Autoload\ClassLoader(\dirname(__DIR__)); | |||
| self::$loader = $loader = new \Composer\Autoload\ClassLoader(\dirname(__DIR__)); | |||
There was a problem hiding this comment.
We need a custom scoped namespace or it can clash with other libraries.
| spl_autoload_unregister(array('ComposerAutoloaderInit8bd2b6d4ccd6b50e0809e5ba62169420', 'loadClassLoader')); | ||
|
|
||
| require __DIR__ . '/autoload_static.php'; | ||
| call_user_func(\Wordlift_Modules_Common_Composer\Autoload\ComposerStaticInit8bd2b6d4ccd6b50e0809e5ba62169420::getInitializer($loader)); | ||
| call_user_func(\Composer\Autoload\ComposerStaticInit8bd2b6d4ccd6b50e0809e5ba62169420::getInitializer($loader)); |
There was a problem hiding this comment.
We need a custom scoped namespace or it can clash with other libraries.
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| // autoload_static.php @generated by Composer | |||
|
|
|||
| namespace Wordlift_Modules_Common_Composer\Autoload; | |||
| namespace Composer\Autoload; | |||
There was a problem hiding this comment.
We need a custom scoped namespace or it can clash with other libraries.
It was causing this warning: ``` Deprecated: strpos(): Passing null to parameter insideout10#1 ($haystack) of type string is deprecated in /var/www/html/wp-includes/functions.php on line 7300 ``` The root of the warning is: ``` wordlift/admin/class-wordlift-admin-page.php(109): add_submenu_page() ```
antoscarface
force-pushed
the
fix-warnings
branch
from
218b1b9
to
ff8a265
Compare
… () of type string is deprecated
| = 3.8.2 - 2024-09-12 = | ||
| * Add missing parameter to the `pre_as_enqueue_async_action` hook. | ||
| * Bump minimum PHP version to 7.0. | ||
| * Bump minimum WordPress version to 6.4. |
There was a problem hiding this comment.
I think we try to be compatible with WP 5.8+ ?
There was a problem hiding this comment.
right, used the version which fixed the warnings (just one minor up, 3.5.4 -> 3.5.3), so no changes to wp min req
antoscarface
force-pushed
the
fix-warnings
branch
from
b6cba8d
to
bfff6a4
Compare
|
The PR aims to solve some deprecation warnings complained by some users. Here the most important ones:
The first twos come from an oldest Symfony libraries which needs to be updated, inside
modules/common, which requires to have a min PHP req to at least 7.4+ in order to easily upgrade the library without putting checks about PHP version because of it needs different code to load base on server PHP version.Also, I had to fix the bootstrap of PHP scoper autoload in order to include also the "autoload files" which are not supported by PHP scoper. This to solve some missing "native php functions" included by the polyfill libraries of symfony, which are required from the upgraded version of symfony dependencies.
In the PR are also fixes some other minor warnings.
The large edits in the PR comes from the dependencies update.
I tried to keep the commits speaking in order to go though them and undestand the flow of changes.