Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve snapshot issue of LBT14 #638

Closed
clarkliming opened this issue Aug 28, 2023 · 4 comments · Fixed by #645
Closed

resolve snapshot issue of LBT14 #638

clarkliming opened this issue Aug 28, 2023 · 4 comments · Fixed by #645
Assignees

Comments

@clarkliming
Copy link
Contributor

clarkliming commented Aug 28, 2023

insightsengineering/tern#1040

there is breaking change to the current usage of LBt14. Please carefully solve the issue

Snapshot of code has changed:
  old[10:36] vs new[10:36]
        ————————————————————————————————————————————————————————————————————————————————
        Not Low                                    124          122            117      
                Not Low                         74 (55.2%)   76 (56.7%)     80 (60.6%)  
  -             1                               13 (9.7%)    12 (9.0%)       9 (6.8%)   
  +             2                               13 (9.7%)    12 (9.0%)       9 (6.8%)   
  -             2                               13 (9.7%)    16 (11.9%)     11 (8.3%)   
  +             3                               13 (9.7%)    16 (11.9%)     11 (8.3%)   
  -             3                               17 (12.7%)   11 (8.2%)       9 (6.8%)   
  +             4                               17 (12.7%)   11 (8.2%)       9 (6.8%)   
  -             4                                7 (5.2%)     7 (5.2%)       8 (6.1%)   
  +             Missing                          7 (5.2%)     7 (5.2%)       8 (6.1%)   
        1                                           3            6              7       
                Not Low                             0         2 (1.5%)       5 (3.8%)   
  -             1                                1 (0.7%)     2 (1.5%)          0       
  +             2                                1 (0.7%)     2 (1.5%)          0       
  -             2                                   0         1 (0.7%)          0       
  +             3                                   0         1 (0.7%)          0       
  -             3                                2 (1.5%)     1 (0.7%)          0       
  +             4                                2 (1.5%)     1 (0.7%)          0       
  -             4                                   0            0           2 (1.5%)   
  +             Missing                             0            0           2 (1.5%)   
        2                                           2            1              4       
                Not Low                          2 (1.5%)        0           3 (2.3%)   
  -             2                                   0         1 (0.7%)          0       
  +             3                                   0         1 (0.7%)          0       
  -             3                                   0            0           1 (0.8%)   
  +             4                                   0            0           1 (0.8%)   
        3                                           2            3              4       
                Not Low                          2 (1.5%)     2 (1.5%)       3 (2.3%)   
  -             1                                   0         1 (0.7%)       1 (0.8%)   
  +             2                                   0         1 (0.7%)       1 (0.8%)   
        4                                           3            2              0       
                Not Low                          2 (1.5%)     1 (0.7%)          0       
  -             3                                1 (0.7%)        0              0       
  +             4                                1 (0.7%)        0              0       
  -             4                                   0         1 (0.7%)          0       
  +             Missing                             0         1 (0.7%)          0       
@clarkliming clarkliming changed the title resolve issue of resolve issue of LBT14 Aug 28, 2023
@clarkliming clarkliming changed the title resolve issue of LBT14 resolve snapshot issue of LBT14 Aug 28, 2023
@BFalquet
Copy link
Contributor

There seem to be an issue with s_count_occurrences_by_grade. Wait for it to be fixed.

@clarkliming
Copy link
Contributor Author

@BFalquet could you please check if any more action needed from our side?

@BFalquet
Copy link
Contributor

I think we need to drop levels in rmpt01, I am not sure why this changed.

@BFalquet BFalquet self-assigned this Aug 30, 2023
@clarkliming
Copy link
Contributor Author

this is in #639 ; my fault that .drop should be TRUE here.

BFalquet pushed a commit that referenced this issue Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants