-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
alignment difference in snapshot #579
Conversation
🧪 Code Coverage Summary
Diff against main
Results for commit: 798a0795517b27fbc117d4b7a4a9537a86f060fe Minimum allowed coverage is ♻️ This comment has been updated with latest results |
please also update |
R/ael01_nollt.R
Outdated
@@ -24,10 +24,16 @@ ael01_nollt_main <- function(adam_db, | |||
assert_all_tablenames(adam_db, dataset) | |||
assert_valid_variable(adam_db[[dataset]], c(key_cols, disp_cols), label = paste0("adam_db$", dataset)) | |||
|
|||
fmt <- list( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about make it an argument (as we don't have the issue of printing it in spec now it should be fine to use it)
and then users are able to use their own fmt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have changed the name of the argument to follow the convention of rlistings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
address the issue and we can merge |
Update snapshots following changes in upstream packages
thank you for the review