Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alignment difference in snapshot #579

Merged
merged 5 commits into from
Jul 17, 2023
Merged

alignment difference in snapshot #579

merged 5 commits into from
Jul 17, 2023

Conversation

BFalquet
Copy link
Contributor

Update snapshots following changes in upstream packages

thank you for the review

@github-actions
Copy link
Contributor

github-actions bot commented Jul 16, 2023

🧪 $Test coverage: 97.75%$

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  -------------------------------------------------
R/ael01_nollt.R                 21       1  95.24%   72
R/aet01_aesi.R                 149       1  99.33%   211
R/aet01.R                       94       1  98.94%   158
R/aet02.R                       60       0  100.00%
R/aet03.R                       77       0  100.00%
R/aet04.R                       89       0  100.00%
R/aet05_all.R                   11       0  100.00%
R/aet05.R                       36       1  97.22%   101
R/aet10.R                       43       0  100.00%
R/assertions.R                  99       6  93.94%   88-93
R/cfbt01.R                     104       0  100.00%
R/checks.R                      14       0  100.00%
R/chevron_tlg-S4class.R         18       0  100.00%
R/chevron_tlg-S4methods.R      103       0  100.00%
R/cmt01a.R                      77       0  100.00%
R/coxt01.R                      48       1  97.92%   126
R/dmt01.R                       27       0  100.00%
R/dst01.R                       95       0  100.00%
R/dtht01.R                     103       6  94.17%   48, 52-56
R/egt02.R                       37       0  100.00%
R/egt03.R                       61       1  98.36%   127
R/egt05_qtcat.R                 77       0  100.00%
R/ext01.R                       61       1  98.36%   40
R/fstg01.R                      42       1  97.62%   95
R/kmg01.R                       28       1  96.43%   69
R/lbt04.R                       74       0  100.00%
R/lbt05.R                       67       5  92.54%   125-130
R/lbt06.R                       63       3  95.24%   131-134
R/lbt07.R                       94       0  100.00%
R/lbt14.R                       57       0  100.00%
R/lbt15.R                       19       0  100.00%
R/mht01.R                       72       0  100.00%
R/mng01.R                       97       1  98.97%   110
R/pdt01.R                       61       0  100.00%
R/pdt02.R                       69       0  100.00%
R/rmpt01.R                      65      11  83.08%   91-100, 143
R/rspt01.R                      73       3  95.89%   156-159
R/rtables_utils.R              246      17  93.09%   41, 98, 210, 230, 416, 431-433, 435, 453-459, 469
R/standard_rules.R              11       0  100.00%
R/ttet01.R                     129       3  97.67%   229-232
R/utils.R                       65       0  100.00%
R/vst02.R                       47       1  97.87%   107
TOTAL                         2883      65  97.75%

Diff against main

Filename           Stmts    Miss  Cover
---------------  -------  ------  -------
R/ael01_nollt.R       +4       0  +1.12%
TOTAL                 +4       0  +0.00%

Results for commit: 798a0795517b27fbc117d4b7a4a9537a86f060fe

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Jul 16, 2023

Unit Tests Summary

    1 files    50 suites   3m 6s ⏱️
223 tests 165 ✔️   58 💤 0
448 runs  309 ✔️ 139 💤 0

Results for commit f2ea7e9.

♻️ This comment has been updated with latest results.

@clarkliming
Copy link
Contributor

please also update ael01_nollt instead of only updating the snapshots. make sure the terms are left aligned (by default, characters are left aligned)

R/ael01_nollt.R Outdated
@@ -24,10 +24,16 @@ ael01_nollt_main <- function(adam_db,
assert_all_tablenames(adam_db, dataset)
assert_valid_variable(adam_db[[dataset]], c(key_cols, disp_cols), label = paste0("adam_db$", dataset))

fmt <- list(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about make it an argument (as we don't have the issue of printing it in spec now it should be fine to use it)

and then users are able to use their own fmt

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed the name of the argument to follow the convention of rlistings

Copy link
Contributor

@clarkliming clarkliming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@clarkliming
Copy link
Contributor

address the issue and we can merge

@BFalquet BFalquet merged commit d3426e9 into main Jul 17, 2023
23 checks passed
@BFalquet BFalquet deleted the update_snapshots@main branch July 17, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants