Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix separator div in case of wrapping #224

Merged
merged 9 commits into from
Nov 24, 2023
Merged

Conversation

Melkiades
Copy link
Contributor

@Melkiades Melkiades commented Nov 8, 2023

Fixes #221

@Melkiades Melkiades added bug Something isn't working sme Tracks changes for the sme board labels Nov 8, 2023
Copy link
Contributor

github-actions bot commented Nov 8, 2023

badge

Code Coverage Summary

Filename             Stmts    Miss  Cover    Missing
-----------------  -------  ------  -------  -----------------------------------------------------------------------------------------------------------------
R/format_value.R       193      13  93.26%   90, 106-113, 193, 212, 283, 405, 416, 424
R/generics.R           100       7  93.00%   454, 466, 499, 528, 652-658
R/labels.R              55       7  87.27%   49, 55, 64, 105, 133, 142, 146
R/matrix_form.R        468      31  93.38%   419-420, 515, 528-531, 550, 582, 676-677, 692-697, 727-730, 763-764, 796-797, 829, 901, 952, 1003, 1006, 1010
R/mpf_exporters.R      142      14  90.14%   2, 83-85, 183, 223, 228, 411, 414, 420-423, 461
R/page_size.R           45       1  97.78%   171
R/pagination.R         560      29  94.82%   437, 509, 630-631, 636, 699-700, 721-731, 1035, 1042, 1070-1077, 1223-1224, 1236-1237, 1251-1252
R/tostring.R           552      32  94.20%   82, 134, 203, 237, 245, 281, 338-341, 432-436, 443-448, 523, 630-631, 845, 860, 955, 1007, 1048, 1093, 1148, 1155
R/utils.R                3       0  100.00%
TOTAL                 2118     134  93.67%

Diff against main

Filename           Stmts    Miss  Cover
---------------  -------  ------  -------
R/generics.R          +5      +3  -2.79%
R/matrix_form.R       +1       0  +0.01%
R/tostring.R          +6      +1  -0.12%
TOTAL                +12      +4  -0.15%

Results for commit: aac6dfb

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Nov 8, 2023

Unit Tests Summary

    1 files      4 suites   7s ⏱️
  35 tests   35 ✔️ 0 💤 0
232 runs  232 ✔️ 0 💤 0

Results for commit aac6dfb.

♻️ This comment has been updated with latest results.

@@ -252,6 +254,7 @@ MatrixPrintForm <- function(strings = NULL,
page_titles = character(),
main_footer = "",
prov_footer = character(),
header_section_div = NA_character_,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

class definition does not need this as it is not a full S4 (I think)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this default should not create problems in rlistings

NEWS.md Outdated Show resolved Hide resolved
Signed-off-by: Davide Garolini <[email protected]>
Copy link
Contributor

github-actions bot commented Nov 21, 2023

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
table_inset and titles and footers word wrapping 👶 $+0.02$ toString_and_wrapping_cooperates_well_with_separator_divisors

Results for commit 7babd38

♻️ This comment has been updated with latest results.

@Melkiades Melkiades requested review from edelarua and ayogasekaram and removed request for edelarua and ayogasekaram November 23, 2023 10:45
Copy link
Contributor

@edelarua edelarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good. Thanks!!

@Melkiades Melkiades merged commit 514e4e5 into main Nov 24, 2023
23 checks passed
@Melkiades Melkiades deleted the 221_fix_separator_div@main branch November 24, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working sme Tracks changes for the sme board
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: toString fails when section dividers are present AND cell wrapping occurs
2 participants