Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing infinite loop for specific strings (e.g. "10 . 4", width of 2) #231

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

Melkiades
Copy link
Contributor

Fixes #230

@Melkiades Melkiades added bug Something isn't working sme Tracks changes for the sme board priority labels Nov 27, 2023
Copy link
Contributor

badge

Code Coverage Summary

Filename             Stmts    Miss  Cover    Missing
-----------------  -------  ------  -------  ------------------------------------------------------------------------------------------------------------------------
R/format_value.R       193      13  93.26%   88, 104-111, 191, 210, 281, 403, 414, 422
R/generics.R           105       7  93.33%   454, 466, 499, 528, 652-658
R/labels.R              55       7  87.27%   49, 55, 64, 105, 133, 142, 146
R/matrix_form.R        469      31  93.39%   425-426, 521, 534-537, 556, 588, 682-683, 698-703, 733-736, 769-770, 802-803, 835, 907, 958, 1009, 1012, 1016
R/mpf_exporters.R      142      14  90.14%   2, 85-87, 185, 225, 230, 413, 416, 422-425, 463
R/page_size.R           45       1  97.78%   171
R/pagination.R         560      29  94.82%   437, 509, 630-631, 636, 699-700, 721-731, 1035, 1042, 1070-1077, 1223-1224, 1236-1237, 1251-1252
R/tostring.R           571      38  93.35%   29-34, 91, 143, 212, 246, 254, 290, 347-350, 443-447, 454-459, 537, 644-645, 863, 878, 973, 1025, 1066, 1111, 1166, 1173
R/utils.R                3       0  100.00%
TOTAL                 2143     140  93.47%

Diff against main

Filename        Stmts    Miss  Cover
------------  -------  ------  -------
R/tostring.R       +3       0  +0.04%
TOTAL              +3       0  +0.01%

Results for commit: 2d21bbe

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

Unit Tests Summary

    1 files      4 suites   7s ⏱️
  36 tests   36 ✔️ 0 💤 0
240 runs  240 ✔️ 0 💤 0

Results for commit 2d21bbe.

Copy link
Contributor

@edelarua edelarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks Davide!! :)

@Melkiades Melkiades merged commit 0f813b3 into main Nov 28, 2023
23 checks passed
@Melkiades Melkiades deleted the 649_fix_loop@main branch November 28, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority sme Tracks changes for the sme board
Projects
None yet
2 participants