Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LBT14 to use correct denom #155

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

edelarua
Copy link
Contributor

@edelarua edelarua commented Oct 17, 2024

Downstream changes resulting from insightsengineering/tern#1326. No other templates are affected.

@edelarua edelarua added the sme label Oct 17, 2024
Copy link
Contributor

github-actions bot commented Oct 17, 2024

Unit Tests Summary

  1 files  111 suites   3m 14s ⏱️
243 tests 243 ✅ 0 💤 0 ❌
513 runs  513 ✅ 0 💤 0 ❌

Results for commit 4397683.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Oct 17, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
pagination_table 💔 $12.05$ $+2.56$ $+9$ $-6$ $0$ $0$
table_aet03 💔 $1.59$ $+3.05$ $+4$ $-1$ $0$ $0$
table_aet04 💔 $5.99$ $+6.55$ $+14$ $-8$ $0$ $0$
table_pkct01 💔 $1.37$ $+1.60$ $+6$ $-2$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
pagination_table 💔 $1.42$ $+2.29$ Pagination_works_for_page_types
table_aet03 💔 $1.59$ $+3.05$ AET03_variant_1_is_produced_correctly
table_aet04 💔 $0.95$ $+1.00$ AET04_variant_3_is_produced_correctly_Fill_in_of_Grades_
table_pkct01 💔 $1.03$ $+1.43$ Specific_PKCT01_features_are_present

Results for commit 640a22b

♻️ This comment has been updated with latest results.

Copy link
Contributor

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks @edelarua

let's not merge this yet. I would like to wait help from @pawelru to show us using pak and compare

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants