Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wave 1 - tm_a_mmrm shinytests #1131

Merged
merged 29 commits into from
May 7, 2024
Merged

Wave 1 - tm_a_mmrm shinytests #1131

merged 29 commits into from
May 7, 2024

Conversation

kartikeyakirar
Copy link
Contributor

Part of #1108

@kartikeyakirar kartikeyakirar marked this pull request as draft April 22, 2024 15:57
@kartikeyakirar kartikeyakirar mentioned this pull request Apr 22, 2024
Closed
42 tasks
@gogonzo gogonzo linked an issue Apr 23, 2024 that may be closed by this pull request
Implement shinytest2 for tmc #1108
Closed
42 tasks
@m7pr m7pr added the core label Apr 23, 2024
@m7pr
Copy link
Contributor

m7pr commented Apr 23, 2024

key @kartikeyakirar I added label and Project

@kartikeyakirar kartikeyakirar marked this pull request as ready for review April 25, 2024 07:56
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 25, 2024 •
edited
Loading

Unit Tests Summary

  1 files   40 suites   20m 1s ⏱️
394 tests 284 ✅ 110 💤 0 ❌
956 runs  734 ✅ 222 💤 0 ❌

Results for commit 680bb70.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 25, 2024 •
edited
Loading

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-tm_a_gee 👶 $+121.13$ $+48$ $0$ $0$ $0$
shinytest2-tm_a_mmrm 👶 $+505.05$ $+309$ $0$ $0$ $0$
shinytest2-tm_g_barchart_simple 👶 $+209.85$ $+73$ $0$ $0$ $0$
shinytest2-tm_g_ci 👶 $+98.58$ $+41$ $0$ $0$ $0$
shinytest2-tm_g_forest_rsp 👶 $+163.57$ $+48$ $0$ $0$ $0$
shinytest2-tm_g_ipp 👶 $+99.38$ $+45$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
shinytest2-tm_a_gee 👶 $+7.39$ e2e_tm_a_gee_Change_in_arm_var_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_a_gee 👶 $+6.83$ e2e_tm_a_gee_Deselection_of_arm_var_throws_validation_error.
shinytest2-tm_a_gee 👶 $+6.81$ e2e_tm_a_gee_Deselection_of_conf_level_throws_validation_error.
shinytest2-tm_a_gee 👶 $+6.72$ e2e_tm_a_gee_Deselection_of_cor_struct_does_not_throw_validation_error.
shinytest2-tm_a_gee 👶 $+6.81$ e2e_tm_a_gee_Deselection_of_id_var_throws_validation_error.
shinytest2-tm_a_gee 👶 $+6.82$ e2e_tm_a_gee_Deselection_of_paramcd_throws_validation_error.
shinytest2-tm_a_gee 👶 $+7.32$ e2e_tm_a_gee_Deselection_of_visit_var_throws_validation_error.
shinytest2-tm_a_gee 👶 $+7.13$ e2e_tm_a_gee_Module_initializes_in_teal_without_errors_and_produces_table_output.
shinytest2-tm_a_gee 👶 $+7.35$ e2e_tm_a_gee_Selection_of_conf_level_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_a_gee 👶 $+6.79$ e2e_tm_a_gee_Selection_of_conf_level_out_of_0_1_range_throws_validation_error.
shinytest2-tm_a_gee 👶 $+7.25$ e2e_tm_a_gee_Selection_of_cor_struct_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_a_gee 👶 $+7.43$ e2e_tm_a_gee_Selection_of_cov_var_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_a_gee 👶 $+7.67$ e2e_tm_a_gee_Selection_of_id_var_does_not_change_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_a_gee 👶 $+7.24$ e2e_tm_a_gee_Selection_of_output_table_changes_the_table_and_doesn_t_throw_validation_error.
shinytest2-tm_a_gee 👶 $+7.39$ e2e_tm_a_gee_Selection_of_paramcd_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_a_gee 👶 $+7.53$ e2e_tm_a_gee_Selection_of_visit_var_does_not_change_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_a_gee 👶 $+6.66$ e2e_tm_a_gee_Starts_with_specified_label_id_var_arm_var_visit_var_paramcd_cov_var_conf_level_and_conf_struct.
shinytest2-tm_a_mmrm 👶 $+7.18$ e2e_tm_a_mmrm_Click_on_fit_model_shows_table_for_default_selection.
shinytest2-tm_a_mmrm 👶 $+8.99$ e2e_tm_a_mmrm_Deselection_of_arm_var_throws_validation_error_in_methodg_mmrm_diagnostic
shinytest2-tm_a_mmrm 👶 $+9.08$ e2e_tm_a_mmrm_Deselection_of_arm_var_throws_validation_error_in_methodg_mmrm_lsmeans
shinytest2-tm_a_mmrm 👶 $+8.41$ e2e_tm_a_mmrm_Deselection_of_arm_var_throws_validation_error_in_methodt_mmrm_cov
shinytest2-tm_a_mmrm 👶 $+8.48$ e2e_tm_a_mmrm_Deselection_of_arm_var_throws_validation_error_in_methodt_mmrm_diagnostic
shinytest2-tm_a_mmrm 👶 $+8.52$ e2e_tm_a_mmrm_Deselection_of_arm_var_throws_validation_error_in_methodt_mmrm_fixed
shinytest2-tm_a_mmrm 👶 $+8.42$ e2e_tm_a_mmrm_Deselection_of_arm_var_throws_validation_error_in_methodt_mmrm_lsmeans
shinytest2-tm_a_mmrm 👶 $+8.88$ e2e_tm_a_mmrm_Deselection_of_aval_var_throws_validation_error_in_methodg_mmrm_diagnostic
shinytest2-tm_a_mmrm 👶 $+8.85$ e2e_tm_a_mmrm_Deselection_of_aval_var_throws_validation_error_in_methodg_mmrm_lsmeans
shinytest2-tm_a_mmrm 👶 $+8.31$ e2e_tm_a_mmrm_Deselection_of_aval_var_throws_validation_error_in_methodt_mmrm_cov
shinytest2-tm_a_mmrm 👶 $+8.36$ e2e_tm_a_mmrm_Deselection_of_aval_var_throws_validation_error_in_methodt_mmrm_diagnostic
shinytest2-tm_a_mmrm 👶 $+8.49$ e2e_tm_a_mmrm_Deselection_of_aval_var_throws_validation_error_in_methodt_mmrm_fixed
shinytest2-tm_a_mmrm 👶 $+8.31$ e2e_tm_a_mmrm_Deselection_of_aval_var_throws_validation_error_in_methodt_mmrm_lsmeans
shinytest2-tm_a_mmrm 👶 $+8.92$ e2e_tm_a_mmrm_Deselection_of_conf_level_throws_validation_error_in_methodg_mmrm_diagnostic
shinytest2-tm_a_mmrm 👶 $+8.75$ e2e_tm_a_mmrm_Deselection_of_conf_level_throws_validation_error_in_methodg_mmrm_lsmeans
shinytest2-tm_a_mmrm 👶 $+8.35$ e2e_tm_a_mmrm_Deselection_of_conf_level_throws_validation_error_in_methodt_mmrm_cov
shinytest2-tm_a_mmrm 👶 $+8.30$ e2e_tm_a_mmrm_Deselection_of_conf_level_throws_validation_error_in_methodt_mmrm_diagnostic
shinytest2-tm_a_mmrm 👶 $+8.43$ e2e_tm_a_mmrm_Deselection_of_conf_level_throws_validation_error_in_methodt_mmrm_fixed
shinytest2-tm_a_mmrm 👶 $+8.20$ e2e_tm_a_mmrm_Deselection_of_conf_level_throws_validation_error_in_methodt_mmrm_lsmeans
shinytest2-tm_a_mmrm 👶 $+8.87$ e2e_tm_a_mmrm_Deselection_of_id_var_throws_validation_error_in_methodg_mmrm_diagnostic
shinytest2-tm_a_mmrm 👶 $+8.77$ e2e_tm_a_mmrm_Deselection_of_id_var_throws_validation_error_in_methodg_mmrm_lsmeans
shinytest2-tm_a_mmrm 👶 $+8.36$ e2e_tm_a_mmrm_Deselection_of_id_var_throws_validation_error_in_methodt_mmrm_cov
shinytest2-tm_a_mmrm 👶 $+8.39$ e2e_tm_a_mmrm_Deselection_of_id_var_throws_validation_error_in_methodt_mmrm_diagnostic
shinytest2-tm_a_mmrm 👶 $+8.56$ e2e_tm_a_mmrm_Deselection_of_id_var_throws_validation_error_in_methodt_mmrm_fixed
shinytest2-tm_a_mmrm 👶 $+8.23$ e2e_tm_a_mmrm_Deselection_of_id_var_throws_validation_error_in_methodt_mmrm_lsmeans
shinytest2-tm_a_mmrm 👶 $+8.77$ e2e_tm_a_mmrm_Deselection_of_visit_var_throws_validation_error_in_methodg_mmrm_diagnostic
shinytest2-tm_a_mmrm 👶 $+8.89$ e2e_tm_a_mmrm_Deselection_of_visit_var_throws_validation_error_in_methodg_mmrm_lsmeans
shinytest2-tm_a_mmrm 👶 $+8.11$ e2e_tm_a_mmrm_Deselection_of_visit_var_throws_validation_error_in_methodt_mmrm_cov
shinytest2-tm_a_mmrm 👶 $+8.37$ e2e_tm_a_mmrm_Deselection_of_visit_var_throws_validation_error_in_methodt_mmrm_diagnostic
shinytest2-tm_a_mmrm 👶 $+8.55$ e2e_tm_a_mmrm_Deselection_of_visit_var_throws_validation_error_in_methodt_mmrm_fixed
shinytest2-tm_a_mmrm 👶 $+8.24$ e2e_tm_a_mmrm_Deselection_of_visit_var_throws_validation_error_in_methodt_mmrm_lsmeans
shinytest2-tm_a_mmrm 👶 $+8.90$ e2e_tm_a_mmrm_Deselection_paramcd_throws_validation_error_in_methodg_mmrm_diagnostic
shinytest2-tm_a_mmrm 👶 $+8.91$ e2e_tm_a_mmrm_Deselection_paramcd_throws_validation_error_in_methodg_mmrm_lsmeans
shinytest2-tm_a_mmrm 👶 $+8.39$ e2e_tm_a_mmrm_Deselection_paramcd_throws_validation_error_in_methodt_mmrm_cov
shinytest2-tm_a_mmrm 👶 $+8.38$ e2e_tm_a_mmrm_Deselection_paramcd_throws_validation_error_in_methodt_mmrm_diagnostic
shinytest2-tm_a_mmrm 👶 $+8.20$ e2e_tm_a_mmrm_Deselection_paramcd_throws_validation_error_in_methodt_mmrm_fixed
shinytest2-tm_a_mmrm 👶 $+8.18$ e2e_tm_a_mmrm_Deselection_paramcd_throws_validation_error_in_methodt_mmrm_lsmeans
shinytest2-tm_a_mmrm 👶 $+5.85$ e2e_tm_a_mmrm_Module_initializes_in_teal_without_errors_and_displays_a_message_to_click_Fit_Model_
shinytest2-tm_a_mmrm 👶 $+6.69$ e2e_tm_a_mmrm_Module_initializes_with_specified_label_aval_var_paramcd_visit_var_cov_var_arm_var_buckets_combine_comp_arms_id_var_cor_struct_weights_emmeans_conf_level_method_parallel_and_output_function
shinytest2-tm_a_mmrm 👶 $+17.57$ e2e_tm_a_mmrm_Validate_output_on_different_selection_on_method_g_mmrm_diagnostic
shinytest2-tm_a_mmrm 👶 $+26.56$ e2e_tm_a_mmrm_Validate_output_on_different_selection_on_method_g_mmrm_lsmeans
shinytest2-tm_a_mmrm 👶 $+24.56$ e2e_tm_a_mmrm_Validate_output_on_different_selection_on_method_t_mmrm_cov
shinytest2-tm_a_mmrm 👶 $+24.91$ e2e_tm_a_mmrm_Validate_output_on_different_selection_on_method_t_mmrm_diagnostic
shinytest2-tm_a_mmrm 👶 $+25.69$ e2e_tm_a_mmrm_Validate_output_on_different_selection_on_method_t_mmrm_fixed
shinytest2-tm_a_mmrm 👶 $+26.86$ e2e_tm_a_mmrm_Validate_output_on_different_selection_on_method_t_mmrm_lsmeans
shinytest2-tm_a_mmrm 👶 $+9.85$ e2e_tm_a_mmrm_function_g_mmrm_diagnostic_selection_shows_output_settings_changingsettings_throws_no_validation_errors_and_verify_visibility_of_generated_plots.
shinytest2-tm_a_mmrm 👶 $+13.06$ e2e_tm_a_mmrm_function_g_mmrm_lsmeans_selection_shows_output_settings_changingsettings_throws_no_validation_errors_and_verify_visibility_of_generated_plots.
shinytest2-tm_a_mmrm 👶 $+9.12$ e2e_tm_a_mmrm_function_t_mmrm_lsmeans_selection_shows_output_settings_changingsettings_throws_no_validation_errors_and_verify_visibility_of_generated_tables.
shinytest2-tm_g_barchart_simple 👶 $+8.83$ e2e_tm_g_barchart_simple_Changing_barlayout_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_barchart_simple 👶 $+8.95$ e2e_tm_g_barchart_simple_Changing_expand_y_range_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_barchart_simple 👶 $+8.79$ e2e_tm_g_barchart_simple_Changing_facet_scale_x_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_barchart_simple 👶 $+9.19$ e2e_tm_g_barchart_simple_Changing_facet_scale_y_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_barchart_simple 👶 $+8.80$ e2e_tm_g_barchart_simple_Changing_flip_axis_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_barchart_simple 👶 $+9.38$ e2e_tm_g_barchart_simple_Changing_label_bars_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_barchart_simple 👶 $+11.16$ e2e_tm_g_barchart_simple_Changing_rotate_bar_labels_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_barchart_simple 👶 $+8.90$ e2e_tm_g_barchart_simple_Changing_rotate_x_label_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_barchart_simple 👶 $+8.87$ e2e_tm_g_barchart_simple_Changing_rotate_y_label_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_barchart_simple 👶 $+8.98$ e2e_tm_g_barchart_simple_Changing_show_n_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_barchart_simple 👶 $+9.47$ e2e_tm_g_barchart_simple_De_selection_of_fill_dataset_changes_the_element_and_does_not_throw_validation_errors
shinytest2-tm_g_barchart_simple 👶 $+8.55$ e2e_tm_g_barchart_simple_De_selection_of_x_facet_dataset_changes_the_element_and_does_not_throw_validation_errors
shinytest2-tm_g_barchart_simple 👶 $+8.66$ e2e_tm_g_barchart_simple_De_selection_of_y_facet_dataset_changes_the_element_and_does_not_throw_validation_errors
shinytest2-tm_g_barchart_simple 👶 $+7.64$ e2e_tm_g_barchart_simple_Deselection_of_x_throws_validation_error.
shinytest2-tm_g_barchart_simple 👶 $+8.61$ e2e_tm_g_barchart_simple_Duplicate_between_x_and_fill_selection_throws_validation_error
shinytest2-tm_g_barchart_simple 👶 $+9.18$ e2e_tm_g_barchart_simple_Duplicate_between_x_and_x_facet_selection_throws_validation_error
shinytest2-tm_g_barchart_simple 👶 $+9.35$ e2e_tm_g_barchart_simple_Duplicate_between_x_and_y_facet_selection_throws_validation_error
shinytest2-tm_g_barchart_simple 👶 $+7.05$ e2e_tm_g_barchart_simple_Module_initializes_in_teal_without_errors_and_produces_output.
shinytest2-tm_g_barchart_simple 👶 $+11.11$ e2e_tm_g_barchart_simple_Selection_of_fill_dataset_changes_the_element_and_does_not_throw_validation_errors
shinytest2-tm_g_barchart_simple 👶 $+9.47$ e2e_tm_g_barchart_simple_Selection_of_x_changes_the_element_and_does_not_throw_validation_errors
shinytest2-tm_g_barchart_simple 👶 $+10.55$ e2e_tm_g_barchart_simple_Selection_of_x_facet_dataset_changes_the_element_and_does_not_throw_validation_errors
shinytest2-tm_g_barchart_simple 👶 $+10.47$ e2e_tm_g_barchart_simple_Selection_of_y_facet_dataset_changes_the_element_and_does_not_throw_validation_errors
shinytest2-tm_g_barchart_simple 👶 $+7.91$ e2e_tm_g_barchart_simple_Starts_with_specified_label_id_var_arm_var_visit_var_paramcd_cov_var_conf_level_and_conf_struct.
shinytest2-tm_g_ci 👶 $+6.85$ e2e_tm_g_ci_Deselecting_AVISIT_filter_value_throws_validation_error.
shinytest2-tm_g_ci 👶 $+6.80$ e2e_tm_g_ci_Deselecting_PARAMCD_filter_value_throws_validation_error.
shinytest2-tm_g_ci 👶 $+7.15$ e2e_tm_g_ci_Deselecting_color_column_changes_plot_output_and_doesn_t_throw_validation_error.
shinytest2-tm_g_ci 👶 $+6.84$ e2e_tm_g_ci_Deselecting_x_var_column_throws_validation_error.
shinytest2-tm_g_ci 👶 $+6.86$ e2e_tm_g_ci_Deselecting_y_var_column_throws_validation_error.
shinytest2-tm_g_ci 👶 $+6.98$ e2e_tm_g_ci_Module_initializes_with_specified_label_x_var_y_var_ADLB_filters_color_conf_level_and_stat.
shinytest2-tm_g_ci 👶 $+7.37$ e2e_tm_g_ci_Selecting_AVISIT_filter_value_doesn_t_throw_validation_errors.
shinytest2-tm_g_ci 👶 $+7.26$ e2e_tm_g_ci_Selecting_PARAMCD_filter_value_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ci 👶 $+7.26$ e2e_tm_g_ci_Selecting_color_column_changes_plot_output_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ci 👶 $+7.20$ e2e_tm_g_ci_Selecting_confidence_interval_value_changes_plot_and_doesn_t_throw_any_errors.
shinytest2-tm_g_ci 👶 $+7.17$ e2e_tm_g_ci_Selecting_statistic_to_use_changes_a_plot_and_doesn_t_throw_any_errors.
shinytest2-tm_g_ci 👶 $+7.29$ e2e_tm_g_ci_Selecting_x_var_column_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ci 👶 $+7.26$ e2e_tm_g_ci_Selecting_y_var_column_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ci 👶 $+6.29$ e2e_tm_g_ci_example_ci_module_initializes_in_teal_without_errors_and_produces_plot_output.
shinytest2-tm_g_forest_rsp 👶 $+9.48$ e2e_tm_g_forest_rsp_Changing_font_size_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp 👶 $+9.42$ e2e_tm_g_forest_rsp_Changing_rel_width_forest_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp 👶 $+8.34$ e2e_tm_g_forest_rsp_Deselecting_arm_var_throws_validation_error.
shinytest2-tm_g_forest_rsp 👶 $+8.86$ e2e_tm_g_forest_rsp_Deselecting_conf_level_or_selecting_outside_the_range_of_0_1_throws_validation_error.
shinytest2-tm_g_forest_rsp 👶 $+8.35$ e2e_tm_g_forest_rsp_Deselecting_paramcd_throws_validation_error.
shinytest2-tm_g_forest_rsp 👶 $+8.09$ e2e_tm_g_forest_rsp_Deselecting_responders_throws_validation_error.
shinytest2-tm_g_forest_rsp 👶 $+9.43$ e2e_tm_g_forest_rsp_Deselecting_strata_var_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp 👶 $+9.02$ e2e_tm_g_forest_rsp_Deselecting_subgroup_var_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp 👶 $+7.47$ e2e_tm_g_forest_rsp_Module_initializes_in_teal_without_errors_and_produces_plot_output.
shinytest2-tm_g_forest_rsp 👶 $+8.24$ e2e_tm_g_forest_rsp_Module_initializes_with_specified_label_arm_var_paramcd_aval_var_responders_subgroup_var_strata_var_conf_level_fixed_symbol_size_rel_width_forest_font_size.
shinytest2-tm_g_forest_rsp 👶 $+8.40$ e2e_tm_g_forest_rsp_Selecting_a_non_factors_column_in_subgroup_var_throws_validation_error.
shinytest2-tm_g_forest_rsp 👶 $+9.59$ e2e_tm_g_forest_rsp_Selecting_arm_var_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp 👶 $+9.58$ e2e_tm_g_forest_rsp_Selecting_conf_level_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp 👶 $+10.78$ e2e_tm_g_forest_rsp_Selecting_paramcd_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp 👶 $+9.57$ e2e_tm_g_forest_rsp_Selecting_responders_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp 👶 $+9.59$ e2e_tm_g_forest_rsp_Selecting_strata_var_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp 👶 $+9.87$ e2e_tm_g_forest_rsp_Selecting_subgroup_var_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp 👶 $+9.51$ e2e_tm_g_forest_rsp_Unsetting_fixed_symbol_size_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ipp 👶 $+7.13$ e2e_tm_g_ipp_Changing_add_avalu_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ipp 👶 $+7.25$ e2e_tm_g_ipp_Changing_add_baseline_hline_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ipp 👶 $+7.44$ e2e_tm_g_ipp_Changing_separate_by_obs_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ipp 👶 $+7.18$ e2e_tm_g_ipp_Changing_suppress_legend_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ipp 👶 $+6.90$ e2e_tm_g_ipp_Deselecting_arm_var_column_throws_validation_error.
shinytest2-tm_g_ipp 👶 $+6.94$ e2e_tm_g_ipp_Deselecting_aval_var_throws_validation_error.
shinytest2-tm_g_ipp 👶 $+6.93$ e2e_tm_g_ipp_Deselecting_paramcd_throws_validation_error.
shinytest2-tm_g_ipp 👶 $+7.00$ e2e_tm_g_ipp_Deselecting_visit_var_throws_validation_error.
shinytest2-tm_g_ipp 👶 $+6.32$ e2e_tm_g_ipp_Module_initializes_in_teal_without_errors_and_produces_plot_output.
shinytest2-tm_g_ipp 👶 $+7.32$ e2e_tm_g_ipp_Selecting_arm_var_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ipp 👶 $+7.26$ e2e_tm_g_ipp_Selecting_aval_var_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ipp 👶 $+7.28$ e2e_tm_g_ipp_Selecting_paramcd_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ipp 👶 $+7.33$ e2e_tm_g_ipp_Selecting_visit_var_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ipp 👶 $+7.11$ e2e_tm_g_ipp_Starts_with_specified_label_parentname_arm_var_paramcd_id_var_visit_var_aval_var_avalu_var_baseline_var_add_baseline_hline_separate_by_obs_suppress_legend_add_avalu.

Results for commit 8f3df06

♻️ This comment has been updated with latest results.

@m7pr
Copy link
Contributor

m7pr commented Apr 25, 2024

@kartikeyakirar there is one R CMD issue

@vedhav vedhav self-assigned this Apr 30, 2024
vedhav
vedhav reviewed Apr 30, 2024
View reviewed changes
Copy link
Contributor

@vedhav vedhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments, please have a look.

tests/testthat/test-shinytest2-tm_a_mmrm.R Outdated Show resolved Hide resolved
tests/testthat/test-shinytest2-tm_a_mmrm.R Outdated Show resolved Hide resolved
tests/testthat/test-shinytest2-tm_a_mmrm.R Outdated Show resolved Hide resolved
tests/testthat/test-shinytest2-tm_a_mmrm.R Outdated Show resolved Hide resolved
tests/testthat/test-shinytest2-tm_a_mmrm.R Outdated Show resolved Hide resolved
tests/testthat/test-shinytest2-tm_a_mmrm.R Outdated Show resolved Hide resolved
tests/testthat/test-shinytest2-tm_a_mmrm.R Outdated Show resolved Hide resolved
@kartikeyakirar
Copy link
Contributor Author

kartikeyakirar commented Apr 30, 2024 •
edited
Loading

bug found based on shinytest2:
#1153
#1151

@kartikeyakirar
Copy link
Contributor Author

@vedhav updated tests as per your suggestions. Please have another look at this.

@vedhav
Copy link
Contributor

vedhav commented May 3, 2024 •
edited
Loading

@kartikeyakirar what do you think about auto-clicking the "Fit Model" when the app driver is created? Looks like we do it all the time, it makes sense to do it during initialization with an option to skip if if we do not need it.
If you like the idea feel free to review and merge the PR #1176 Also, feel free to close the PR without merging if you do not want it this way. This is just a special module so I felt that it makes sense to have this.

vedhav and others added 3 commits May 3, 2024 20:04
@vedhav
Add fit_model to app_driver_tm_a_mmrm (#1176)
fedf270 
Add `fit_model` to `app_driver_tm_a_mmrm` so that the click
automatically happens when the app driver is created
@kartikeyakirar
@vedhav suggestion
a95c347
@kartikeyakirar
@vedhav suggestions.
43cd167
@kartikeyakirar kartikeyakirar requested a review from vedhav May 6, 2024 08:33
vedhav
vedhav approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@vedhav vedhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Since this module tests multiple selections it is a little more complex compared to other modules and that's okay.

@vedhav vedhav merged commit d285a0f into shinytest2@main May 7, 2024
26 checks passed
@vedhav vedhav deleted the 1108_shinytest2_tm_a_mmrm@shinytest2@main branch May 7, 2024 11:16
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@m7pr m7pr m7pr left review comments

@vedhav vedhav vedhav approved these changes

Assignees

@vedhav vedhav

Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement shinytest2 for tmc
4 participants
@kartikeyakirar @m7pr @vedhav @averissimo