Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove assertion that has conflict with goshawk #129

Merged
merged 2 commits into from
Dec 8, 2022
Merged

remove assertion that has conflict with goshawk #129

merged 2 commits into from
Dec 8, 2022

Conversation

BLAZEWIM
Copy link
Contributor

@BLAZEWIM BLAZEWIM commented Dec 8, 2022 •
edited
Loading

Fixes #128

@BLAZEWIM BLAZEWIM added the core label Dec 8, 2022
@BLAZEWIM BLAZEWIM requested a review from Polkas December 8, 2022 14:21
@BLAZEWIM BLAZEWIM mentioned this pull request Dec 8, 2022
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2022 •
edited
Loading

Unit Tests Summary

    1 files      9 suites   9s ⏱️
  88 tests   86 ✔️ 2 💤 0 ❌
175 runs  173 ✔️ 2 💤 0 ❌

Results for commit 551227a.

♻️ This comment has been updated with latest results.

@Polkas
Copy link
Contributor

Polkas commented Dec 8, 2022

Please add recommended by @nikolas-burkoff null.ok argument and do not remove the assertion.

@BLAZEWIM
nullok
551227a 
Signed-off-by: Marek Blazewicz <[email protected]>
Polkas
Polkas approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@Polkas Polkas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BLAZEWIM BLAZEWIM merged commit d1a1c2a into main Dec 8, 2022
@BLAZEWIM BLAZEWIM deleted the 128_remove_assertion@main branch December 8, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Polkas Polkas Polkas approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

brushed points causing problems
2 participants
@BLAZEWIM @Polkas