125 tws tests srv@main #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhallal1
reviewed
Dec 12, 2022
mhallal1
reviewed
Dec 12, 2022
mhallal1
reviewed
Dec 12, 2022
mhallal1
reviewed
Dec 12, 2022
Co-authored-by: Mahmoud Hallal <[email protected]> Signed-off-by: Marek Blazewicz <[email protected]>
Co-authored-by: Mahmoud Hallal <[email protected]> Signed-off-by: Marek Blazewicz <[email protected]>
Co-authored-by: Mahmoud Hallal <[email protected]> Signed-off-by: Marek Blazewicz <[email protected]>
mhallal1
reviewed
Dec 12, 2022
mhallal1
reviewed
Dec 12, 2022
mhallal1
reviewed
Dec 12, 2022
Co-authored-by: Mahmoud Hallal <[email protected]> Signed-off-by: Marek Blazewicz <[email protected]>
Co-authored-by: Mahmoud Hallal <[email protected]> Signed-off-by: Marek Blazewicz <[email protected]>
Co-authored-by: Mahmoud Hallal <[email protected]> Signed-off-by: Marek Blazewicz <[email protected]>
Merged
mhallal1
approved these changes
Dec 14, 2022
BLAZEWIM
added a commit
that referenced
this pull request
Jan 12, 2023
Fixes #[132](#132) Presented are two options (main file: tests/testthat/test-table_with_settings_ui.R) for testing table with settings using shinytest2, to discuss and decide on one of them (or a mix): 1. Maximum option (`app_tws_maxi`), which is a almost exact copy of a recoreded test, with tesing downloads a a lot of `app$set_inputs()` usage. Cons: We test download in the other place (#131). Pros: we test the exact table content and look, not its existence. 2. Minimum option (`app_tws_mini`), where we test clicks and use minimum number of `app$set_inputs()` required. We mainly check the values at output (.json file). In both options, decision whether we use '.png' snapshots is to be decided based on how it goes in review on other machines (how stable it is). Signed-off-by: Marek Blazewicz <[email protected]> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: 27856297+dependabot-preview[bot]@users.noreply.github.com <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Mahmoud Hallal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #125
Server tests for table with settings, similiar to #113