Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plot with settings test ui #135

Merged
merged 10 commits into from
Jan 11, 2023
Merged

plot with settings test ui #135

merged 10 commits into from
Jan 11, 2023

Conversation

BLAZEWIM
Copy link
Contributor

Fixes #109

@BLAZEWIM BLAZEWIM added the core label Dec 21, 2022
@BLAZEWIM BLAZEWIM changed the title initial push for 109 plot with settings test ui Dec 21, 2022
@mhallal1 mhallal1 marked this pull request as ready for review December 24, 2022 12:13
@github-actions
Copy link
Contributor

github-actions bot commented Dec 24, 2022 •
edited
Loading

badge

Code Coverage Summary

Filename                   Stmts    Miss  Cover    Missing
-----------------------  -------  ------  -------  ----------------------------------------------------------
R/basic_table_args.R          23       0  100.00%
R/draggable_buckets.R         82      82  0.00%    57-152
R/get_dt_rows.R               13      13  0.00%    27-39
R/ggplot2_args.R              49       0  100.00%
R/include_css_js.R             7       1  85.71%   17
R/optionalInput.R            218     185  15.14%   78-353, 405, 440, 444, 448, 450, 456, 471-484
R/panel_group.R               89      89  0.00%    12-130
R/plot_with_settings.R       382      24  93.72%   271-284, 306, 343-344, 355-356, 365-366, 610-611, 613, 615
R/standard_layout.R           40       0  100.00%
R/table_with_settings.R      171       0  100.00%
R/utils.R                      4       1  75.00%   7
R/verbatim_popup.R           100      49  51.00%   64-79, 105-106, 108, 116-144, 165
R/white_small_well.R           7       7  0.00%    18-24
TOTAL                       1185     451  61.94%

Diff against main

Filename                   Stmts    Miss  Cover
-----------------------  -------  ------  -------
R/table_with_settings.R        0     -51  +29.82%
R/verbatim_popup.R            +4      +2  -0.04%
TOTAL                         +4     -49  +4.28%

Results for commit: 6863314

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Jan 10, 2023 •
edited
Loading

Unit Tests Summary

    1 files    10 suites   9s ⏱️
  96 tests   93 ✔️ 3 💤 0 ❌
200 runs  197 ✔️ 3 💤 0 ❌

Results for commit fa4c66d.

♻️ This comment has been updated with latest results.

BLAZEWIM and others added 2 commits January 10, 2023 10:54
@BLAZEWIM @gogonzo
Update tests/testthat/test-plot_with_settings_ui.R
2d7a7c5 
ctrl c ctrl v mistake...

Co-authored-by: Dawid Kałędkowski <[email protected]>
Signed-off-by: Marek Blazewicz <[email protected]>
@BLAZEWIM @gogonzo
Update tests/testthat/helpers-with-settings.R
fa4c66d 
Co-authored-by: Dawid Kałędkowski <[email protected]>
Signed-off-by: Marek Blazewicz <[email protected]>
gogonzo
gogonzo approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@gogonzo gogonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@BLAZEWIM BLAZEWIM merged commit fce6bc9 into main Jan 11, 2023
@BLAZEWIM BLAZEWIM deleted the 109_pws_ui@main branch January 11, 2023 16:58
BLAZEWIM added a commit that referenced this pull request Jan 11, 2023
@BLAZEWIM
Revert "plot with settings test ui (#135)"
539691a 
This reverts commit fce6bc9.
@BLAZEWIM BLAZEWIM restored the 109_pws_ui@main branch January 11, 2023 17:02
@BLAZEWIM BLAZEWIM deleted the 109_pws_ui@main branch January 12, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gogonzo gogonzo gogonzo approved these changes

@mhallal1 mhallal1 Awaiting requested review from mhallal1

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BLAZEWIM @gogonzo