Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a delayed reactive to observe flex width #173

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

vedhav
Copy link
Contributor

@vedhav vedhav commented Aug 4, 2023

Closes #172

@vedhav vedhav added the core label Aug 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

badge

Code Coverage Summary

Filename                   Stmts    Miss  Cover    Missing
-----------------------  -------  ------  -------  ---------------------------------------------
R/basic_table_args.R          23       0  100.00%
R/draggable_buckets.R         82      82  0.00%    57-152
R/get_dt_rows.R               13      13  0.00%    27-39
R/ggplot2_args.R              49       0  100.00%
R/include_css_js.R             7       1  85.71%   17
R/optionalInput.R            218     185  15.14%   87-362, 414, 449, 453, 457, 459, 465, 480-493
R/panel_group.R               89      89  0.00%    12-130
R/plot_with_settings.R       383      21  94.52%   272-285, 344-345, 356-357, 611-612, 614, 616
R/standard_layout.R           40       0  100.00%
R/table_with_settings.R      173       1  99.42%   79
R/utils.R                      4       1  75.00%   7
R/verbatim_popup.R           100      49  51.00%   64-79, 105-106, 108, 116-144, 165
R/white_small_well.R           7       7  0.00%    18-24
TOTAL                       1188     449  62.21%

Diff against main

Filename                  Stmts    Miss  Cover
----------------------  -------  ------  -------
R/plot_with_settings.R       +1       0  +0.01%
TOTAL                        +1       0  +0.03%

Results for commit: 700e2ba

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

Unit Tests Summary

    1 files    10 suites   15s ⏱️
  97 tests   97 ✔️ 0 💤 0
204 runs  204 ✔️ 0 💤 0

Results for commit 2eac1ff.

♻️ This comment has been updated with latest results.

@kartikeyakirar
Copy link
Contributor

@vedhav, the pull request did not pass one of the unit tests on GitHub. Could you please review and investigate?

@vedhav
Copy link
Contributor Author

vedhav commented Aug 7, 2023

Just added a commit to address it.

Copy link
Contributor

@chlebowa chlebowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@vedhav vedhav merged commit 76ce610 into main Aug 7, 2023
20 checks passed
@vedhav vedhav deleted the 172-fix-auto-width-reactivity@main branch August 7, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Auto plot width triggers the plot observers too often than needed
3 participants