-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
various docs enhancements #182
Conversation
DESCRIPTION
Outdated
@@ -29,6 +29,7 @@ Imports: | |||
shinyWidgets, | |||
styler | |||
Suggests: | |||
grDevices, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixing previous mistake of not adding a package that is used in the tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually this should be even in imports as one functionality depends on this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is on main now:
teal.widgets/R/plot_with_settings.R
Lines 406 to 408 in f75ce74
grDevices::pdf(NULL) # reset Rplots.pdf for shiny server | |
w <- grDevices::dev.size("px")[1] | |
grDevices::dev.off() |
@@ -21,6 +21,7 @@ Imports: | |||
checkmate, | |||
ggplot2, | |||
graphics, | |||
grDevices, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI @averissimo - change in deps
Code Coverage Summary
Diff against main
Results for commit: 6fa9a2c Minimum allowed coverage is ♻️ This comment has been updated with latest results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some more minor tweaks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exploding PRs happen all too often 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup 👌
@chlebowa thanks for a good review comments! |
teal
teal.widgets
teal.widgets::foo()
->foo()
beam
NULL
, shiny.tag ->shiny.tag
, etc. (including docs, error message, testthat label)grDevices
to pkg Imports - that is actually an error on the current state of main