Only retain hard dependencies from pre-commit hooks

[vedhav]

insightsengineering/coredev-tasks/issues/471

[github-actions]

Code Coverage Summary

Filename                   Stmts    Miss  Cover    Missing
-----------------------  -------  ------  -------  --------------------------------------------
R/basic_table_args.R          23       0  100.00%
R/draggable_buckets.R         82      82  0.00%    57-152
R/get_dt_rows.R               13      13  0.00%    27-39
R/ggplot2_args.R              49       0  100.00%
R/include_css_js.R             7       1  85.71%   17
R/optionalInput.R            225     182  19.11%   87-362, 414, 465, 471, 486-499
R/panel_group.R               90      90  0.00%    12-132
R/plot_with_settings.R       382      21  94.50%   272-285, 344-345, 356-357, 607-608, 610, 612
R/standard_layout.R           35       0  100.00%
R/table_with_settings.R      173       1  99.42%   79
R/utils.R                     11       1  90.91%   7
R/verbatim_popup.R            99      49  50.51%   63-78, 104-105, 107, 115-143, 164
R/white_small_well.R           7       7  0.00%    18-24
TOTAL                       1196     447  62.63%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 0231341

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

[github-actions]

Unit Tests Summary

    1 files    10 suites   20s ⏱️
101 tests 101 ✔️ 0 💤 0 ❌
208 runs  208 ✔️ 0 💤 0 ❌

Results for commit 30af8e8.

♻️ This comment has been updated with latest results.

[donyunardi]

Tried to trigger the hooks and I got some warnings:

I think we need to add rtables.

[vedhav]

Thanks for catching this @donyunardi. Since we are using rtables inside the package functions it should be an Imports dependency in the DESCRIPTION file too right?

[pawelru]

Thanks for catching this @donyunardi. Since we are using rtables inside the package functions it should be an Imports dependency in the DESCRIPTION file too right?

See #154. Let me also summon @m7pr who analysed this already.

[m7pr]

Hey, commented in #154 . Having second thoughts, I would bring back rtables to Imports. I never had any strong preference towards any approach (Suggests nor Imports) but it looks like rtables is used in 3 functions, and this Suggests trick is bringing more issues than it actually helps.

[donyunardi]

LGTM!

I'm approving this but can you please add NEWS.md to show that we're moving rtables back to Imports?