Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix verdepcheck #253

Merged
merged 5 commits into from
Aug 5, 2024
Merged

Fix verdepcheck #253

merged 5 commits into from
Aug 5, 2024

Conversation

pawelru
Copy link
Contributor

@pawelru pawelru commented Jul 30, 2024

v2.12.3 is the earliest for which we have a binary available. Anything earlier fails to build from source as reported here

Copy link
Contributor

github-actions bot commented Jul 30, 2024

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

@pawelru
Copy link
Contributor Author

pawelru commented Jul 30, 2024

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

github-actions bot commented Jul 30, 2024

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  -------------------------------------------------
R/basic_table_args.R             23       0  100.00%
R/draggable_buckets.R            82      82  0.00%    58-153
R/get_dt_rows.R                  13      13  0.00%    44-56
R/ggplot2_args.R                 49       0  100.00%
R/include_css_js.R                7       1  85.71%   17
R/nested_closeable_modal.R       16      16  0.00%    83-98
R/optionalInput.R               255     212  16.86%   149-447, 501, 554, 560, 575-588
R/panel_group.R                  90      90  0.00%    50-190
R/plot_with_settings.R          371      22  94.07%   282-295, 317, 354-355, 366-367, 641-642, 644, 646
R/standard_layout.R              35       0  100.00%
R/table_with_settings.R         173       1  99.42%   85
R/utils.R                        14       1  92.86%   7
R/verbatim_popup.R               99      49  50.51%   65-80, 106-107, 109, 117-145, 166
R/white_small_well.R              7       7  0.00%    19-25
TOTAL                          1234     494  59.97%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 6e07546

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@pawelru pawelru enabled auto-merge (squash) July 30, 2024 13:11
Copy link
Contributor

github-actions bot commented Jul 30, 2024

Unit Tests Summary

  1 files   11 suites   1m 20s ⏱️
122 tests 118 ✅ 4 💤 0 ❌
323 runs  319 ✅ 4 💤 0 ❌

Results for commit 6e07546.

♻️ This comment has been updated with latest results.

Copy link
Contributor

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
plot_with_settings_ui 💔 $38.81$ $+1.27$ $0$ $0$ $0$ $0$
table_with_settings_ui 💔 $30.73$ $+1.05$ $0$ $0$ $0$ $0$

Results for commit 17eae6b

♻️ This comment has been updated with latest results.

@pawelru pawelru requested a review from donyunardi July 31, 2024 07:08
@pawelru pawelru merged commit 21b350f into main Aug 5, 2024
30 checks passed
@pawelru pawelru deleted the fix_verdepcheck branch August 5, 2024 08:42
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants