feat: added a verbatim_popup module
#59
Conversation
| if (inherits(verbatim_content, "reactive")) { | ||
| shiny::validate(shiny::need( | ||
| checkmate::assert_multi_class(verbatim_content(), classes = c("expression", "character")) | ||
| )) |
There was a problem hiding this comment.
Initially, I had this validation somewhere else, now I am not sure it needs to be here or inside the module function (I think inside the module :( )
Code Coverage SummaryResults for commit: c5c20ba Minimum allowed coverage is ♻️ This comment has been updated with latest results |
| export(verbatim_popup_srv) | ||
| export(verbatim_popup_ui) |
There was a problem hiding this comment.
please modify _pkgdown accordingly
There was a problem hiding this comment.
I am just curious why pkgdown workflow does not complain. That should be catched automatically. Will you be able to have a look at this and create a task for IDR if necessary? Many thanks!
There was a problem hiding this comment.
? It is there, isn't it?
|
Badges added. Pkgdown unchanged, it already lists |
Closes #30
Test with the example replacing the contents of the modal. Also, have a look at the tests for examples of what should be allowed and what should not be allowed into the modal.
The idea is that behaviour is the same as the previous
get_rcodemodule but without theget_eval_detailspart.This just shows the content formatted as verbatim. Be aware that it will not format properly without
shinys bundled CSS, so it will not look as intended when the UI function is called outside of ashinyobject (like a fluid page in the example).I replaced the bloated
clipboard.jswith our own, custom js. Should be short enough to maintain.I would be glad if someone with MacOS tested the copying function because I have read about some edge cases with the Navigator API and MacOS. I have put some fallback code inspired by an so post, but I would sleep better if it was tested.