Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update plot_with_settings.R - dim slot #63

Merged
merged 4 commits into from
Jul 5, 2022
Merged

Update plot_with_settings.R - dim slot #63

merged 4 commits into from
Jul 5, 2022

Conversation

Polkas
Copy link
Contributor

@Polkas Polkas commented Jul 4, 2022 •
edited
Loading

closes #62

Added the dim slot to the list returned by the plot_with_settings module.
It will be consumed by e.g. teal.reporter when append_plot is used.

@Polkas Polkas added the core label Jul 4, 2022
@Polkas Polkas mentioned this pull request Jul 4, 2022
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2022 •
edited
Loading

Unit Tests Summary

  1 files    5 suites   1s ⏱️
55 tests 55 ✔️ 0 💤 0 ❌
99 runs  99 ✔️ 0 💤 0 ❌

Results for commit f543a26.

♻️ This comment has been updated with latest results.

@Polkas Polkas changed the title Update plot_with_settings.R Update plot_with_settings.R - dim slot Jul 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2022 •
edited
Loading

Code Coverage Summary

Filename                   Stmts    Miss  Cover    Missing
-----------------------  -------  ------  -------  -------------------------
R/accordion.R                 45      45  0.00%    12-62
R/basic_table_args.R          23       0  100.00%
R/draggable_buckets.R         84      84  0.00%    44-141
R/get_dt_rows.R               13      13  0.00%    27-39
R/ggplot2_args.R              49       0  100.00%
R/include_css_js.R             7       7  0.00%    12-19
R/optionalInput.R            201     201  0.00%    78-458
R/panel_group.R               68      68  0.00%    15-127
R/plot_with_settings.R       378     372  1.59%    8-583
R/standard_layout.R           40       0  100.00%
R/table_with_settings.R      167     167  0.00%    11-236
R/verbatim_popup.R            76      48  36.84%   43-65, 80-81, 83, 104-128
R/white_small_well.R           5       5  0.00%    18-22
TOTAL                       1156    1010  12.63%

Results for commit: 4ea78ef

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

mhallal1
mhallal1 reviewed Jul 5, 2022
View reviewed changes
R/plot_with_settings.R Outdated
@@ -451,7 +451,8 @@ plot_with_settings_srv <- function(id,
input$height
input$width
input$plot_hover
})
}),
dim = reactive(c(input$width_in_modal, input$height_in_modal))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am getting NULL for dim always?

@Polkas Polkas closed this Jul 5, 2022
@Polkas Polkas deleted the 62_hw@main branch July 5, 2022 08:10
@Polkas Polkas restored the 62_hw@main branch July 5, 2022 08:36
@Polkas Polkas reopened this Jul 5, 2022
@Polkas Polkas merged commit a361589 into main Jul 5, 2022
@Polkas Polkas deleted the 62_hw@main branch July 5, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhallal1 mhallal1 mhallal1 approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

plot_with_settings returns a plot width and height
2 participants
@Polkas @mhallal1