Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update css #68

Merged
merged 27 commits into from
Jul 28, 2022
Merged

update css #68

merged 27 commits into from
Jul 28, 2022

Conversation

Polkas
Copy link
Contributor

@Polkas Polkas commented Jul 22, 2022

linked to https://github.com/insightsengineering/coredev-tasks/issues/225

  • remove inline css rule
  • DRY
  • style at the head - tags$head(includeCSS())

@Polkas Polkas marked this pull request as ready for review July 26, 2022 11:06
@github-actions
Copy link
Contributor

github-actions bot commented Jul 26, 2022

Unit Tests Summary

  1 files    5 suites   2s ⏱️
55 tests 55 ✔️ 0 💤 0
99 runs  99 ✔️ 0 💤 0

Results for commit fe773ea.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 26, 2022

Code Coverage Summary

Filename                   Stmts    Miss  Cover    Missing
-----------------------  -------  ------  -------  -------------------------
R/accordion.R                 45      45  0.00%    12-62
R/basic_table_args.R          23       0  100.00%
R/draggable_buckets.R         82      82  0.00%    44-139
R/get_dt_rows.R               13      13  0.00%    27-39
R/ggplot2_args.R              49       0  100.00%
R/include_css_js.R             7       7  0.00%    12-19
R/optionalInput.R            208     208  0.00%    78-462
R/panel_group.R               67      67  0.00%    15-126
R/plot_with_settings.R       378     372  1.59%    8-583
R/standard_layout.R           40       0  100.00%
R/table_with_settings.R      167     167  0.00%    11-236
R/verbatim_popup.R            79      51  35.44%   43-65, 80-81, 83, 104-131
R/white_small_well.R           7       7  0.00%    18-24
TOTAL                       1165    1019  12.53%

Results for commit: defa731

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@Polkas Polkas added the core label Jul 26, 2022
@nikolas-burkoff nikolas-burkoff self-assigned this Jul 27, 2022
Copy link
Contributor

@nikolas-burkoff nikolas-burkoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments inline - also:
image

div(id = "pre-output", pre_output),
div(id = "output", output),
div(id = "post-output", post_output)
div(class = "pre-output", pre_output),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess technically this is a breaking change (as someone may have referred to pre-output the id in their custom css file) so we should probably add a news entry for this

R/verbatim_popup.R Outdated Show resolved Hide resolved
R/plot_with_settings.R Outdated Show resolved Hide resolved
Copy link
Contributor

@nikolas-burkoff nikolas-burkoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Polkas Polkas merged commit d8bc8cb into main Jul 28, 2022
@Polkas Polkas deleted the core_225_css@main branch July 28, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants