-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update css #68
update css #68
Conversation
Code Coverage Summary
Results for commit: defa731 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
div(id = "pre-output", pre_output), | ||
div(id = "output", output), | ||
div(id = "post-output", post_output) | ||
div(class = "pre-output", pre_output), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess technically this is a breaking change (as someone may have referred to pre-output the id in their custom css file) so we should probably add a news entry for this
Co-authored-by: Nikolas Burkoff <[email protected]>
This reverts commit 7b576e3.
This reverts commit 281ac1d.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
linked to https://github.com/insightsengineering/coredev-tasks/issues/225