-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix disabling verbatim popup button #81
Conversation
Code Coverage Summary
Diff against main
Results for commit: b139b5c Minimum allowed coverage is ♻️ This comment has been updated with latest results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -52,7 +52,7 @@ verbatim_popup_srv <- function(id, verbatim_content, title, style = FALSE, disab | |||
checkmate::assert_class(disabled, classes = "reactive") | |||
moduleServer(id, function(input, output, session) { | |||
ns <- session$ns | |||
disabled_flag_observer(disabled, ns("button")) | |||
disabled_flag_observer(disabled, "button") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this is because shinyjs handles the module namespace...
Tested with mmrm in tmc and it works
Although this is on branch 26_new_chunks@main I still recommend merging it into main now as it is a bugfix independent of the refactor