Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix disabling verbatim popup button #81

Merged
merged 1 commit into from
Sep 1, 2022
Merged

Conversation

nikolas-burkoff
Copy link
Contributor

@nikolas-burkoff nikolas-burkoff commented Sep 1, 2022

Tested with mmrm in tmc and it works

Although this is on branch 26_new_chunks@main I still recommend merging it into main now as it is a bugfix independent of the refactor

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2022

badge

Code Coverage Summary

Filename                   Stmts    Miss  Cover    Missing
-----------------------  -------  ------  -------  -------------------------
R/accordion.R                 45      45  0.00%    12-62
R/basic_table_args.R          23       0  100.00%
R/draggable_buckets.R         82      82  0.00%    44-139
R/get_dt_rows.R               13      13  0.00%    27-39
R/ggplot2_args.R              49       0  100.00%
R/include_css_js.R             7       7  0.00%    12-19
R/optionalInput.R            208     208  0.00%    78-462
R/panel_group.R               67      67  0.00%    15-126
R/plot_with_settings.R       378     372  1.59%    8-583
R/standard_layout.R           40       0  100.00%
R/table_with_settings.R      167     167  0.00%    11-236
R/verbatim_popup.R            85      48  43.53%   49-64, 79-80, 82, 104-132
R/white_small_well.R           7       7  0.00%    18-24
TOTAL                       1171    1016  13.24%

Diff against main

Filename              Stmts    Miss  Cover
------------------  -------  ------  -------
R/verbatim_popup.R       +1      +1  -0.52%
TOTAL                    +1      +1  -0.01%

Results for commit: b139b5c

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

@gogonzo gogonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -52,7 +52,7 @@ verbatim_popup_srv <- function(id, verbatim_content, title, style = FALSE, disab
checkmate::assert_class(disabled, classes = "reactive")
moduleServer(id, function(input, output, session) {
ns <- session$ns
disabled_flag_observer(disabled, ns("button"))
disabled_flag_observer(disabled, "button")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is because shinyjs handles the module namespace...

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2022

Unit Tests Summary

  1 files    5 suites   1s ⏱️
55 tests 55 ✔️ 0 💤 0
99 runs  99 ✔️ 0 💤 0

Results for commit fc8d1a5.

@nikolas-burkoff nikolas-burkoff merged commit 8aa0e70 into main Sep 1, 2022
@nikolas-burkoff nikolas-burkoff deleted the 26_new_chunks@main branch September 1, 2022 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants