Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

teal.widgets - bs345 #84

Merged
merged 18 commits into from
Sep 27, 2022
Merged

teal.widgets - bs345 #84

merged 18 commits into from
Sep 27, 2022

Conversation

Polkas
Copy link
Contributor

@Polkas Polkas commented Sep 5, 2022

linked to teal/#709](insightsengineering/teal#719)

  • remove not used functionality to record if the panel item is clicked from the server perspective.
  • panel group and panel item working under all bootstrap versions 3,4 and 5
  • remove not needed div in the standard_layout to make it working under all bootstrap versions

Example for panel_(group/item):

library(shiny)

ui <- fluidPage(
  theme = bslib::bs_theme(version = "4"), # test 3, 4 and 5
  teal.widgets::panel_item("Item1", "Hey"),
  teal.widgets::panel_group(teal.widgets::panel_item("Item1", "Hey"), teal.widgets::panel_item("Item2", "Hey")),
  teal.widgets::panel_item("Item2", "Hey"),
  teal.widgets::panel_item("Item3", "Hey")
)

server <- function(input, output, session) {
  
}

shinyApp(ui, server)

@Polkas Polkas added the core label Sep 5, 2022
@Polkas Polkas changed the title rm not needed div in the standard layout teal.widgets - bs345 Sep 5, 2022
NEWS.md Outdated
@@ -1,5 +1,8 @@
# teal.widgets 0.1.1.9013

### Breaking changes
* `panel_group` and `panel_item` are no longer offer to be optionally a shiny input.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be a little clearer - it's the css class name rather than the panel group itself?

NEWS.md Outdated Show resolved Hide resolved
@Polkas Polkas marked this pull request as ready for review September 19, 2022 08:02
@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2022

Unit Tests Summary

    1 files      7 suites   1s ⏱️
  63 tests   63 ✔️ 0 💤 0
109 runs  109 ✔️ 0 💤 0

Results for commit edb723a.

♻️ This comment has been updated with latest results.

NEWS.md Outdated Show resolved Hide resolved
@asbates
Copy link
Contributor

asbates commented Sep 23, 2022

lgtm

@donyunardi donyunardi self-requested a review September 23, 2022 21:05
Copy link
Contributor

@donyunardi donyunardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@donyunardi donyunardi merged commit f97dcb3 into main Sep 27, 2022
@donyunardi donyunardi deleted the 709_bs345@main branch September 27, 2022 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants