allow trace for invalid quosures

NEWS.md

@@ -3,10 +3,11 @@
 ### Enhancements
 * Updated `standard_layout` function to contain class not id for each output block.
 * Added the `dim` slot to the list returned by the `plot_with_settings` module.
-* Added `style` argument to `verbatim_popup_srv` to control whether the content is styled using `styler::style_text`
+* Added `style` argument to `verbatim_popup_srv` to control whether the content is styled using `styler::style_text`.
+* `condition` objects can now be displayed in `verbatim_popup`.
 
 ### Bug fixes
-* fixed bug in `verbatim_popup_srv` where `disabled` argument didn't influence the popup button. 
+* Fixed bug in `verbatim_popup_srv` where `disabled` argument didn't influence the popup button. 
 
 ### New features
 * Added a new module - `verbatim_popup`.

R/verbatim_popup.R

@@ -38,10 +38,11 @@ verbatim_popup_ui <- function(id, button_label, ...) {
 #' @name verbatim_popup
 #' @export
 #'
-#' @param verbatim_content (`character`, `expression` or `reactive(1)` holding either)
-#' the content to show in the popup modal window
+#' @param verbatim_content (`character`, `expression`, `condition` or `reactive(1)`
+#' holding any of the above) the content to show in the popup modal window
 #' @param title (`character(1)`) the title of the modal window
-#' @param style (`logical(1)`) whether to style the `verbatim_content` using `styler::style_text`
+#' @param style (`logical(1)`) whether to style the `verbatim_content` using `styler::style_text`.
+#' If `verbatim_content` is a `condition` or `reactive` holding `condition` then this argument is ignored
 #' @param disabled (`reactive(1)`) the `shiny` reactive value holding a `logical`. The popup button is disabled
 #' when the flag is `TRUE` and enabled otherwise
 #'
@@ -147,18 +148,23 @@ button_click_observer <- function(click_event, copy_button_id, copied_area_id, m
 format_content <- function(verbatim_content, style = FALSE) {
   shiny::reactive({
     content <- if (inherits(verbatim_content, "reactive")) {
-      verbatim_content()
+      tryCatch(
+        verbatim_content(),
+        error = function(e) {
+          e
+        }
+      )
     } else {
       verbatim_content
     }
     shiny::validate(shiny::need(
-      checkmate::test_multi_class(content, classes = c("expression", "character")),
-      "verbatim_content should be an expression or a character"
+      checkmate::test_multi_class(content, classes = c("expression", "character", "condition")),
+      "verbatim_content should be an expression, character or condition"
     ))
 
     content <- paste(as.character(content), collapse = "\n")
 
-    if (style) {
+    if (style && !checkmate::test_class(content, "condition")) {
       content <- paste(styler::style_text(content), collapse = "\n")
     }
     content

tests/testthat/test-verbatim_popup.R

@@ -13,6 +13,18 @@ testthat::test_that("format_content returns a `shiny` reactive when passed a rea
   testthat::expect_true(inherits(format_content(test_content), "reactive"))
 })
 
+testthat::test_that("format_content returns a reactive when passed a condition", {
+  test_content <- structure("Test Content", clas = "condition")
+  testthat::expect_true(inherits(format_content(test_content), "reactive"))
+})
+
+testthat::test_that("format_content returns a reactive when passed a reactive holding a condition", {
+  test_content <- shiny::reactive({
+    validate(need(1 > 4, "1 is less than 4"))
+  })
+  testthat::expect_true(inherits(format_content(test_content), "reactive"))
+})
+
 testthat::test_that("format_content concatenates the passed array of strings", {
   test_content <- c("Test", "Content")
   result <- shiny::isolate(format_content(test_content))
@@ -31,7 +43,6 @@ testthat::test_that("format_content concatenates the passed array of string insi
   testthat::expect_length(result, 1)
 })
 
-
 testthat::test_that(
   "format_content returns a reactive storing a styled string when passed
   an expression, character or reactive when style = TRUE",