Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optionalSliderInput - out of range #89

Merged
merged 6 commits into from
Sep 20, 2022
Merged

optionalSliderInput - out of range #89

merged 6 commits into from
Sep 20, 2022

Conversation

Polkas
Copy link
Contributor

@Polkas Polkas commented Sep 20, 2022

closes #88

Fixed the optionalSliderInput conditional which assumed only single value for the slider position.
Another fix are proper values when min and max are NA.

@Polkas Polkas added the core label Sep 20, 2022
@Polkas Polkas self-assigned this Sep 20, 2022
@Polkas Polkas changed the title out of range optionalSliderInput - out of range Sep 20, 2022
@Polkas Polkas marked this pull request as ready for review September 20, 2022 08:26
Copy link
Contributor

@nikolas-burkoff nikolas-burkoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments but looks good

NEWS.md Outdated Show resolved Hide resolved
R/optionalInput.R Outdated Show resolved Hide resolved
R/optionalInput.R Outdated Show resolved Hide resolved
Co-authored-by: Nikolas Burkoff <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2022

Unit Tests Summary

    1 files      6 suites   1s ⏱️
  62 tests   62 ✔️ 0 💤 0
108 runs  108 ✔️ 0 💤 0

Results for commit 2cc8c93.

♻️ This comment has been updated with latest results.

R/optionalInput.R Outdated Show resolved Hide resolved
Copy link
Contributor

@nikolas-burkoff nikolas-burkoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small comment but looks good

@Polkas Polkas enabled auto-merge (squash) September 20, 2022 10:22
@Polkas Polkas merged commit b82acc4 into main Sep 20, 2022
@Polkas Polkas deleted the 88_oslider@main branch September 20, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: optionalSliderInput warns when value is length 2
2 participants