allowed Date and datetime in value_choices (#1226)

* allowed Date and datetime in value_choices * ensure the timezone is shown in value_choices dropdown * used as.POSIXlt to get tzone; added datetime_to_char * spelling * WORDLIST * used format function * removed memoise * Update R/choices_labeled.R Co-Authored-By: Pagacz, Konrad {FIEV~Warsaw} <[email protected]> * Update R/choices_labeled.R * detect when timezone is not present * Update inst/WORDLIST * roxygen2::roxygenize('.', roclets = c('rd', 'collate', 'namespace')) Co-authored-by: Junlue Zhao <[email protected]> Co-authored-by: Pagacz, Konrad {FIEV~Warsaw} <[email protected]>
insightsengineering · Jun 29, 2021 · a14443b · a14443b
1 parent ea6b5b7
commit a14443b
Show file tree

Hide file tree

Showing 134 changed files with 152 additions and 135 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -9,6 +9,7 @@
 
 ### Bug fixes
 * Fixed an edge case error when creating a filter on variable with all missing values crashed the app.
+* Fixed a bug that crashes app whenever a `Date` or `datetime` column is selected from a `filter_spec`.
 
 # teal 0.9.4
 

diff --git a/R/choices_labeled.R b/R/choices_labeled.R
@@ -366,7 +366,23 @@ value_choices.data.frame <- function(data, # nolint
     )
   }
 
-  choices <- if (length(var_choices) > 1 || is.character(df_choices[[1]]) || is.factor(df_choices[[1]])) {
+  choices <- if (
+    length(var_choices) > 1 ||
+    is.character(df_choices[[1]]) ||
+    is.factor(df_choices[[1]]) ||
+    inherits(df_choices[[1]], c("Date", "POSIXct", "POSIXlt", "POSIXt"))
+    ) {
+    df_choices <- dplyr::mutate_if(
+      df_choices,
+      .predicate = function(col) inherits(col, c("POSIXct", "POSIXlt", "POSIXt")),
+      .fun = function(col) {
+        if (is.null(attr(col, "tzone")) || all(attr(col, "tzone") == "")) {
+          format(trunc(col), "%Y-%m-%d %H:%M:%S")
+        } else {
+          format(trunc(col), "%Y-%m-%d %H:%M:%S %Z")
+        }
+      }
+    )
     apply(df_choices, 1, paste, collapse = sep)
   } else {
     df_choices[[var_choices]]

diff --git a/man/CDISCData.Rd b/man/CDISCData.Rd
diff --git a/man/CDISCDataConnector.Rd b/man/CDISCDataConnector.Rd
diff --git a/man/CDISCDataset.Rd b/man/CDISCDataset.Rd
diff --git a/man/CDISCDatasetConnector.Rd b/man/CDISCDatasetConnector.Rd
diff --git a/man/CDISCFilteredData.Rd b/man/CDISCFilteredData.Rd
diff --git a/man/Callable.Rd b/man/Callable.Rd
diff --git a/man/CallableCode.Rd b/man/CallableCode.Rd
diff --git a/man/CallableFunction.Rd b/man/CallableFunction.Rd
diff --git a/man/CallablePythonCode.Rd b/man/CallablePythonCode.Rd
diff --git a/man/CodeClass.Rd b/man/CodeClass.Rd
diff --git a/man/DataAbstract.Rd b/man/DataAbstract.Rd
diff --git a/man/DataConnection.Rd b/man/DataConnection.Rd
diff --git a/man/DatasetConnector.Rd b/man/DatasetConnector.Rd
diff --git a/man/FilteredData.Rd b/man/FilteredData.Rd
diff --git a/man/JoinKeys.Rd b/man/JoinKeys.Rd
diff --git a/man/PythonCodeClass.Rd b/man/PythonCodeClass.Rd
diff --git a/man/RelationalData.Rd b/man/RelationalData.Rd
diff --git a/man/RelationalDataConnector.Rd b/man/RelationalDataConnector.Rd
diff --git a/man/add_no_selected_choices.Rd b/man/add_no_selected_choices.Rd
diff --git a/man/as_cdisc.Rd b/man/as_cdisc.Rd
diff --git a/man/as_cdisc_relational.Rd b/man/as_cdisc_relational.Rd
diff --git a/man/as_relational.Rd b/man/as_relational.Rd
diff --git a/man/bookmarkableShinyApp.Rd b/man/bookmarkableShinyApp.Rd
diff --git a/man/callable_code.Rd b/man/callable_code.Rd
diff --git a/man/callable_function.Rd b/man/callable_function.Rd
diff --git a/man/cdisc_data.Rd b/man/cdisc_data.Rd
diff --git a/man/cdisc_data_file.Rd b/man/cdisc_data_file.Rd
diff --git a/man/cdisc_dataset.Rd b/man/cdisc_dataset.Rd
diff --git a/man/cdisc_dataset_connector.Rd b/man/cdisc_dataset_connector.Rd
diff --git a/man/cdisc_dataset_connector_file.Rd b/man/cdisc_dataset_connector_file.Rd
diff --git a/man/cdisc_dataset_file.Rd b/man/cdisc_dataset_file.Rd
diff --git a/man/choices_labeled.Rd b/man/choices_labeled.Rd