Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The documentation of check_modules_datanames() is incorrect #1321

Open
pawelru opened this issue Aug 14, 2024 · 0 comments
Open

The documentation of check_modules_datanames() is incorrect #1321

pawelru opened this issue Aug 14, 2024 · 0 comments
Labels

Comments

@pawelru
Copy link
Contributor

pawelru commented Aug 14, 2024

Follow-up on #1253

teal/R/utils.R

Line 113 in 9c6d38c

#' @return A `character(1)` containing error message or `TRUE` if validation passes.

But we are returning a list instead. Still figuring out what each of the element means so can't make a suggestion right now

teal/R/utils.R

Lines 138 to 162 in 9c6d38c

list(
string = build_datanames_error_message(
modules$label,
datanames,
extra_datanames,
tags = list(
span = function(..., .noWS = NULL) { # nolint: object_name
trimws(paste(..., sep = ifelse(is.null(.noWS), " ", ""), collapse = " "))
},
code = function(x) toString(dQuote(x, q = FALSE))
),
tagList = function(...) trimws(paste(...))
),
# Build HTML representation of the error message with <pre> formatting
html = function(with_module_name = TRUE) {
tagList(
build_datanames_error_message(
if (with_module_name) modules$label,
datanames,
extra_datanames
),
tags$br(.noWS = "before")
)
}
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants