Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple scda from teal #834

Closed
donyunardi opened this issue May 25, 2023 · 0 comments · Fixed by #858
Closed

Decouple scda from teal #834

donyunardi opened this issue May 25, 2023 · 0 comments · Fixed by #858
Assignees
Labels

Comments

@donyunardi
Copy link
Contributor

donyunardi commented May 25, 2023

Related to insightsengineering/nestdevs-tasks#1

Summary

After careful observation, it appears that the scda package is not essential for teal. Consequently, it is advantageous for us to separate scda from teal.

Files affected:

  • dummy_functions.R
  • init.R (examples)
  • modules_debugging.R (examples)
  • validations.R (examples)
  • including-adam-data-in-teal.Rmd
  • preprocessing-data.Rmd

Acceptance Criteria

  • Use iris, mtcars, or create a minimal example data that resides only within the package for unit tests and roxygen examples.
    This minimal example data will be stored as .rda files in the /data folder.
  • Revise the roxygen examples to use the minimal example data.
  • If applicable, Update the unit tests to utilize the new data.
  • Update affected vignettes.
  • Update DESCRIPTION file to remove scda and related packages.
  • Update staged_dependencies.yml
@gogonzo gogonzo self-assigned this Jun 30, 2023
gogonzo added a commit that referenced this issue Jul 6, 2023
closes #834


see also:
- insightsengineering/scda#125
- insightsengineering/scda.2022#123

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: 27856297+dependabot-preview[bot]@users.noreply.github.com <27856297+dependabot-preview[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants