changes for filter panel constuctor #670
Conversation
R/module_teal.R
Outdated
| datasets <- teal.slice:::filtered_data_new(raw_data()) | ||
| # transfer the datasets from raw_data() into the FilteredData object | ||
| teal.slice:::filtered_data_set(raw_data(), datasets) | ||
| datasets <- do.call(teal.slice::init_filtered_data, raw_data()$get_teal_inputs()) |
There was a problem hiding this comment.
I'm not convinced that TealData should have method to return teal-ready list. I think the "converter" should be here in teal. TealData probably have all methods needed to extract data and attributes already.
There was a problem hiding this comment.
I'm not sure turning teal_data/cdisc_data into a format we need for teal.slice will probably be quite involved (and we need to then have explicit if statement for if you are cdisc or not) for this
There was a problem hiding this comment.
back then initialization of FilteredData was like this. We might have something similar in teal (as private method ofc). Not pushing though, let's see how TealData will be impacted in your proposition.
filtered_data_set.RelationalData <- function(data, datasets) { # nolintr # nousage
datasets$set_code(data$get_code_class())
for (dataset in data$get_datasets()) {
dataname <- get_dataname(dataset)
raw_dataset <- get_raw_data(dataset)
datasets$set_data(dataname, raw_dataset)
datasets$set_data_attrs(dataname, get_attrs(dataset))
datasets$set_data_attr(dataname, "check", data$get_check_result())
}
datasets$set_join_keys(data$get_join_keys())
return(invisible(NULL))
}
Code Coverage SummaryResults for commit: a6a727f Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Co-authored-by: Dawid Kałędkowski <[email protected]>
Co-authored-by: Pawel Rucki <[email protected]>
Requires insightsengineering/teal.slice#49 part of insightsengineering/teal.slice#33