Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix test #688

Merged
merged 2 commits into from
Jul 8, 2022
Merged

fix test #688

merged 2 commits into from
Jul 8, 2022

Conversation

mhallal1
Copy link
Collaborator

@mhallal1 mhallal1 commented Jul 8, 2022

@mhallal1 mhallal1 added the core label Jul 8, 2022
@mhallal1 mhallal1 requested a review from Polkas July 8, 2022 08:36
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2022 •
edited
Loading

Code Coverage Summary

Filename                         Stmts    Miss  Cover    Missing
-----------------------------  -------  ------  -------  -----------------------------------------------
R/default_filter.R                   7       7  0.00%    17-27
R/dummy_functions.R                 74      61  17.57%   12-95
R/example_module.R                  17      17  0.00%    19-35
R/get_rcode_utils.R                 52       2  96.15%   94, 99
R/get_rcode.R                      131      40  69.47%   66, 73, 78, 212-261
R/include_css_js.R                  20       0  100.00%
R/init.R                            39      21  46.15%   171, 182-183, 236-257
R/log_app_usage.R                   38      38  0.00%    34-119
R/logging.R                         13      13  0.00%    11-28
R/module_nested_tabs.R             110      15  86.36%   57, 96, 115-127, 163, 212, 252
R/module_tabs_with_filters.R        52      21  59.62%   111-137
R/module_teal_with_splash.R         33       2  93.94%   62, 74
R/module_teal.R                    119      28  76.47%   49, 52, 142-143, 156-162, 168-174, 197, 227-239
R/modules_debugging.R               19      19  0.00%    41-60
R/modules.R                        109      10  90.83%   218, 287, 415-440
R/reporter_previewer_module.R       12       2  83.33%   18, 22
R/show_rcode_modal.R                20      20  0.00%    17-38
R/utils.R                            6       0  100.00%
R/validations.R                     62      39  37.10%   103-355
R/zzz.R                             11       7  36.36%   3-14
TOTAL                              944     362  61.65%

Results for commit: 82fa47e

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2022 •
edited
Loading

Unit Tests Summary

    1 files    10 suites   15s ⏱️
104 tests 104 ✔️ 0 💤 0 ❌
205 runs  205 ✔️ 0 💤 0 ❌

Results for commit a0fc665.

♻️ This comment has been updated with latest results.

@Polkas Polkas self-assigned this Jul 8, 2022
Polkas
Polkas reviewed Jul 8, 2022
View reviewed changes
tests/testthat/test-get_rcode.R Outdated
Comment on lines 10 to 11
strsplit(r_code_from_chunks, "\n")[[1]][c(1:5, 7:15)],
strsplit(r_code_from_header, "\n")[[1]][c(1:5, 7:15)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On my system should be up to 13 not 15

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it fail?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh or some times 14

Polkas
Polkas reviewed Jul 8, 2022
View reviewed changes
tests/testthat/test-get_rcode.R Outdated
Comment on lines 23 to 24
strsplit(r_code_from_chunks, "\n")[[1]][c(1:5, 7:17)],
strsplit(r_code_from_header, "\n")[[1]][c(1:5, 7:17)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on my system should be up to 15 not 17

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

> length(strsplit(r_code_from_chunks, "\n")[[1]])
[1] 15
> length(strsplit(r_code_from_header, "\n")[[1]])
[1] 15

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the tests to use length so that it is consistent on any platform.

@mhallal1 mhallal1 merged commit ff351d9 into main Jul 8, 2022
@mhallal1 mhallal1 deleted the 687_fix_test@main branch July 8, 2022 09:25
@nikolas-burkoff nikolas-burkoff mentioned this pull request Jan 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Polkas Polkas Polkas approved these changes

Assignees

@Polkas Polkas

Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

teal is failing checks
2 participants
@mhallal1 @Polkas