Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review css #703

Merged
merged 17 commits into from
Jul 29, 2022
Merged

review css #703

merged 17 commits into from
Jul 29, 2022

Conversation

Polkas
Copy link
Contributor

@Polkas Polkas commented Jul 24, 2022

linked to https://github.com/insightsengineering/coredev-tasks/issues/225

  • remove inline css rule
  • DRY
  • style at the head - tags$head(includeCSS())

@Polkas Polkas changed the title style at the head not body review css Jul 25, 2022
@Polkas Polkas added the core label Jul 26, 2022
@Polkas Polkas marked this pull request as ready for review July 26, 2022 09:34
@github-actions
Copy link
Contributor

github-actions bot commented Jul 26, 2022

Code Coverage Summary

Filename                         Stmts    Miss  Cover    Missing
-----------------------------  -------  ------  -------  -------------------------------------------
R/default_filter.R                   7       7  0.00%    17-27
R/dummy_functions.R                 74      61  17.57%   12-95
R/example_module.R                  17      17  0.00%    19-35
R/get_rcode_utils.R                 52       2  96.15%   94, 99
R/get_rcode.R                      131      51  61.07%   66, 73, 78, 139-148, 186, 212-261
R/include_css_js.R                  24       0  100.00%
R/init.R                            39      21  46.15%   171, 182-183, 236-257
R/log_app_usage.R                   38      38  0.00%    34-119
R/logging.R                         13      13  0.00%    11-28
R/module_nested_tabs.R             113      16  85.84%   57, 96, 100-117, 163, 212, 257
R/module_tabs_with_filters.R        65       0  100.00%
R/module_teal_with_splash.R         33       2  93.94%   62, 74
R/module_teal.R                    119      20  83.19%   49, 52, 142-143, 156-162, 168-174, 197, 227
R/modules_debugging.R               19      19  0.00%    41-60
R/modules.R                        115       9  92.17%   218, 423-448
R/reporter_previewer_module.R       12       2  83.33%   18, 22
R/show_rcode_modal.R                20      20  0.00%    17-38
R/utils.R                            6       0  100.00%
R/validations.R                     62      39  37.10%   103-355
R/zzz.R                             11       7  36.36%   3-14
TOTAL                              970     344  64.54%

Results for commit: 7c4466f

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Jul 26, 2022

Unit Tests Summary

    1 files    10 suites   11s ⏱️
107 tests 107 ✔️ 0 💤 0
207 runs  207 ✔️ 0 💤 0

Results for commit c289297.

♻️ This comment has been updated with latest results.

@nikolas-burkoff nikolas-burkoff self-assigned this Jul 27, 2022
Copy link
Contributor

@nikolas-burkoff nikolas-burkoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just the one comment here

}

/* to set the alignment of pickerInput dropdowns */
.dropdown-menu.open {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Polkas Polkas merged commit eb373df into main Jul 29, 2022
@Polkas Polkas deleted the core_225_css@main branch July 29, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants