Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEWS #745

Merged
merged 2 commits into from
Oct 11, 2022
Merged

NEWS #745

merged 2 commits into from
Oct 11, 2022

Conversation

mhallal1
Copy link
Collaborator

@mhallal1 mhallal1 commented Oct 5, 2022

closes #742

@mhallal1 mhallal1 added the core label Oct 5, 2022
mhallal1
mhallal1 commented Oct 5, 2022
View reviewed changes
NEWS.md
* `...` argument in the `teal_module` no longer receives `datasets` object. In order to use `datasets` in the `teal_module` please specify `datasets` explicitly.
* Deprecated `merge_expression` argument in `get_rcode_srv` and `get_rcode` has been removed.
* Updated `teal_module` to no longer receive `datasets` object in the `...` argument. In order to use `datasets` in the `teal_module` please specify `datasets` explicitly.
* Deprecated `merge_expression` argument in `get_rcode_srv` function and removed it in `get_rcode` function.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An issue has been created for this entry: #744

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2022 •
edited
Loading

badge

Code Coverage Summary

Filename                         Stmts    Miss  Cover    Missing
-----------------------------  -------  ------  -------  -------------------------------------------
R/default_filter.R                   7       7  0.00%    17-27
R/dummy_functions.R                 74      61  17.57%   12-95
R/example_module.R                  17      17  0.00%    19-35
R/get_rcode_utils.R                 52       2  96.15%   94, 99
R/get_rcode.R                      131      51  61.07%   66, 73, 78, 139-148, 186, 212-261
R/include_css_js.R                  24       0  100.00%
R/init.R                            39      21  46.15%   174, 185-186, 239-260
R/log_app_usage.R                   38      38  0.00%    34-119
R/logging.R                         13      13  0.00%    11-28
R/module_nested_tabs.R             113      16  85.84%   57, 96, 100-117, 163, 212, 257
R/module_tabs_with_filters.R        68       1  98.53%   160
R/module_teal_with_splash.R         33       2  93.94%   62, 74
R/module_teal.R                    120      20  83.33%   49, 52, 143-144, 157-163, 169-175, 198, 228
R/modules_debugging.R               19      19  0.00%    41-60
R/modules.R                        115       9  92.17%   218, 423-448
R/reporter_previewer_module.R       12       2  83.33%   18, 22
R/show_rcode_modal.R                20      20  0.00%    17-38
R/utils.R                           13       0  100.00%
R/validations.R                     62      39  37.10%   103-355
R/zzz.R                             11       7  36.36%   3-14
TOTAL                              981     345  64.83%

Results for commit: dc9895e

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2022 •
edited
Loading

Unit Tests Summary

    1 files    11 suites   13s ⏱️
108 tests 108 ✔️ 0 💤 0 ❌
211 runs  211 ✔️ 0 💤 0 ❌

Results for commit b9becba.

♻️ This comment has been updated with latest results.

@Polkas Polkas self-assigned this Oct 10, 2022
@Polkas
Copy link
Contributor

Polkas commented Oct 10, 2022

SECURITY and CODE_OF_CONDUCT are new files, they are directed to end users so should be mentioned.

Polkas
Polkas approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@Polkas Polkas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhallal1 mhallal1 merged commit fe2a23c into main Oct 11, 2022
@mhallal1 mhallal1 deleted the 742_NEWS@main branch October 11, 2022 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Polkas Polkas Polkas approved these changes

Assignees

@Polkas Polkas

Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UAT] NEWS.md
3 participants
@mhallal1 @Polkas @donyunardi