Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove root_modules function #754

Merged
merged 4 commits into from
Nov 21, 2022
Merged

remove root_modules function #754

merged 4 commits into from
Nov 21, 2022

Conversation

donyunardi
Copy link
Contributor

Closes #753

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2022

Unit Tests Summary

    1 files    12 suites   13s ⏱️
135 tests 135 ✔️ 0 💤 0
257 runs  257 ✔️ 0 💤 0

Results for commit 008cfab.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2022

badge

Code Coverage Summary

Filename                         Stmts    Miss  Cover    Missing
-----------------------------  -------  ------  -------  -------------------------------------------
R/dummy_functions.R                 74      61  17.57%   12-95
R/example_module.R                  18      18  0.00%    19-36
R/get_rcode_utils.R                 52       2  96.15%   94, 99
R/get_rcode.R                      137      54  60.58%   74, 81, 86, 211-277
R/include_css_js.R                  24       0  100.00%
R/init.R                            39      21  46.15%   173, 184-185, 238-259
R/log_app_usage.R                   38      38  0.00%    34-119
R/logging.R                         13      13  0.00%    11-28
R/module_nested_tabs.R             130       7  94.62%   57, 96, 101-102, 148, 198, 227
R/module_tabs_with_filters.R        68       1  98.53%   160
R/module_teal_with_splash.R         33       2  93.94%   62, 74
R/module_teal.R                    131      20  84.73%   49, 52, 155-156, 169-175, 181-187, 210, 240
R/modules_debugging.R               18      18  0.00%    39-58
R/modules.R                        101       8  92.08%   341-366
R/reporter_previewer_module.R       12       2  83.33%   18, 22
R/show_rcode_modal.R                20      20  0.00%    17-38
R/tdata.R                           41       2  95.12%   146, 172
R/utils.R                           13       0  100.00%
R/validations.R                     62      39  37.10%   103-355
R/zzz.R                             11       7  36.36%   3-14
TOTAL                             1035     333  67.83%

Diff against main

Filename       Stmts    Miss  Cover
-----------  -------  ------  -------
R/modules.R       -9      -1  +0.26%
TOTAL             -9      -1  -0.18%

Results for commit: 77b0b26

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

NEWS.md Outdated Show resolved Hide resolved
Co-authored-by: Konrad Pagacz <[email protected]>
Signed-off-by: Dony Unardi <[email protected]>
@donyunardi
Copy link
Contributor Author

Thanks @kpagacz ! Hope you're doing well =)

@chlebowa chlebowa self-assigned this Nov 18, 2022
@chlebowa chlebowa enabled auto-merge (squash) November 18, 2022 15:00
Copy link
Contributor

@BLAZEWIM BLAZEWIM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, check passed, installation works.

@chlebowa chlebowa merged commit 8ca7805 into main Nov 21, 2022
@chlebowa chlebowa deleted the 753_remove_root_module@main branch November 21, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove soft-deprecated function root_modules
4 participants