Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation fixes for release review #819

Merged
merged 6 commits into from
Apr 5, 2023
Merged

Documentation fixes for release review #819

merged 6 commits into from
Apr 5, 2023

Conversation

asbates
Copy link
Contributor

@asbates asbates commented Apr 3, 2023

Fixes a few documentation issues that need to be addressed for release. Note that not all items from #815 are in this PR. Some of them need discussion, so I opened #818.

Closes #815

@asbates asbates added the core label Apr 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

Unit Tests Summary

    1 files    12 suites   15s ⏱️
143 tests 143 ✔️ 0 💤 0
283 runs  283 ✔️ 0 💤 0

Results for commit 9462952.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

badge

Code Coverage Summary

Filename                         Stmts    Miss  Cover    Missing
-----------------------------  -------  ------  -------  ------------------------------
R/dummy_functions.R                 74      61  17.57%   12-95
R/example_module.R                  18       9  50.00%   23-26, 29-33
R/get_rcode_utils.R                 45       0  100.00%
R/include_css_js.R                  24       0  100.00%
R/init.R                            22       2  90.91%   188-189
R/module_nested_tabs.R             161       7  95.65%   57, 97, 101-102, 137, 188, 240
R/module_tabs_with_filters.R        68       1  98.53%   162
R/module_teal_with_splash.R         33       2  93.94%   65, 77
R/module_teal.R                    111       5  95.50%   49, 52, 155-156, 180
R/modules_debugging.R               18      18  0.00%    37-56
R/modules.R                        101       8  92.08%   341-366
R/reporter_previewer_module.R       12       2  83.33%   18, 22
R/show_rcode_modal.R                20      20  0.00%    17-38
R/tdata.R                           41       2  95.12%   146, 172
R/utils.R                           13       0  100.00%
R/validate_inputs.R                 32       0  100.00%
R/validations.R                     62      39  37.10%   107-368
R/zzz.R                             11       7  36.36%   3-14
TOTAL                              866     183  78.87%

Diff against main

Filename               Stmts    Miss  Cover
-------------------  -------  ------  -------
R/get_rcode_utils.R       -7      -2  +3.85%
TOTAL                     -7      -2  +2.53%

Results for commit: 172f327

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

@donyunardi donyunardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

R/module_nested_tabs.R Show resolved Hide resolved
R/validations.R Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review teal documentation before release
2 participants