Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

867 modify mapping matrix #879

Merged
merged 6 commits into from
Aug 1, 2023
Merged

867 modify mapping matrix #879

merged 6 commits into from
Aug 1, 2023

Conversation

chlebowa
Copy link
Contributor

@chlebowa chlebowa commented Jul 30, 2023

Fixes #867
Fixes #878

The mapping matrix is modified to display filters that cannot be applied to a particular module as NA.

In matrix_to_mapping filters that are NA are treated as TRUE because global filters may not apply to some modules.

Requires a new public method in FilteredData, introduced here.

@chlebowa chlebowa added the core label Jul 30, 2023
@chlebowa chlebowa marked this pull request as ready for review July 30, 2023 15:17
@github-actions
Copy link
Contributor

github-actions bot commented Jul 30, 2023

badge

Code Coverage Summary

Filename                         Stmts    Miss  Cover    Missing
-----------------------------  -------  ------  -------  -----------------------------------------------------------------------------
R/dummy_functions.R                 88      63  28.41%   9-76, 101-104, 107-111
R/get_rcode_utils.R                 46       1  97.83%   49
R/include_css_js.R                  24       0  100.00%
R/init.R                            76      28  63.16%   169-176, 181-202, 214-216
R/module_filter_manager.R          103      29  71.84%   62-70, 79-84, 220, 225-238
R/module_nested_tabs.R             171      16  90.64%   71, 118, 122-123, 137-144, 161, 211, 233, 266
R/module_snapshot_manager.R        140     104  25.71%   71-82, 109-118, 122-134, 136-143, 149-164, 177-200, 203-214, 217-223, 250-273
R/module_tabs_with_filters.R        67       2  97.01%   95, 134
R/module_teal_with_splash.R         33       2  93.94%   65, 77
R/module_teal.R                    164      12  92.68%   68, 71, 158-159, 209-210, 230-233, 235, 239
R/modules_debugging.R               18      18  0.00%    25-44
R/modules.R                        108      11  89.81%   314-357
R/reporter_previewer_module.R       16       2  87.50%   23, 27
R/show_rcode_modal.R                20      20  0.00%    16-37
R/tdata.R                           41       2  95.12%   146, 172
R/teal_reporter.R                   60       5  91.67%   65, 116-117, 120, 137
R/teal_slices.R                     45       0  100.00%
R/utils.R                           21       0  100.00%
R/validate_inputs.R                 32       0  100.00%
R/validations.R                     62      39  37.10%   111-375
R/zzz.R                             11       7  36.36%   3-14
TOTAL                             1346     361  73.18%

Diff against main

Filename                       Stmts    Miss  Cover
---------------------------  -------  ------  -------
R/module_filter_manager.R         +2       0  +0.56%
R/module_snapshot_manager.R       +1      +1  -0.18%
TOTAL                             +3      +1  -0.01%

Results for commit: f85ae6b

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Jul 30, 2023

Unit Tests Summary

    1 files    16 suites   20s ⏱️
171 tests 171 ✔️ 0 💤 0
341 runs  341 ✔️ 0 💤 0

Results for commit 064390e.

♻️ This comment has been updated with latest results.

@gogonzo gogonzo self-assigned this Jul 31, 2023
R/module_filter_manager.R Show resolved Hide resolved
@chlebowa chlebowa merged commit 036eafa into main Aug 1, 2023
22 checks passed
@chlebowa chlebowa deleted the 867_mapping_matrix_NA@main branch August 1, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

render mapping matrix modify mapping_matrix in filter manager module
2 participants