You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are few places where we use strat and strata (and also strata_var) which seems to be inconsistent.
It might be working if strat is required and strata is provided due to R's ability of partial match but we should avoid it (there is a seperate PR aims to punish it). The other way around is not functional.
Please analyse if that's correct.
If to be corrected, note that it's potentially a breaking change so would be nice to give a lifecycle warning and create strata from strat (or vice versa).
This has downstream consequences in chevron, tmc and TLG-Cat - if changed please amend these as well.
The text was updated successfully, but these errors were encountered:
There are few places where we use
strat
andstrata
(and alsostrata_var
) which seems to be inconsistent.It might be working if
strat
is required andstrata
is provided due to R's ability of partial match but we should avoid it (there is a seperate PR aims to punish it). The other way around is not functional.Please analyse if that's correct.
If to be corrected, note that it's potentially a breaking change so would be nice to give a lifecycle warning and create
strata
fromstrat
(or vice versa).This has downstream consequences in
chevron
,tmc
and TLG-Cat - if changed please amend these as well.The text was updated successfully, but these errors were encountered: