Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strat vs strata (vs strata_var) #1186

Closed
pawelru opened this issue Feb 9, 2024 · 0 comments · Fixed by #1198
Closed

strat vs strata (vs strata_var) #1186

pawelru opened this issue Feb 9, 2024 · 0 comments · Fixed by #1198
Assignees
Labels

Comments

@pawelru
Copy link
Contributor

pawelru commented Feb 9, 2024

There are few places where we use strat and strata (and also strata_var) which seems to be inconsistent.

image

image

It might be working if strat is required and strata is provided due to R's ability of partial match but we should avoid it (there is a seperate PR aims to punish it). The other way around is not functional.

Please analyse if that's correct.

If to be corrected, note that it's potentially a breaking change so would be nice to give a lifecycle warning and create strata from strat (or vice versa).

This has downstream consequences in chevron, tmc and TLG-Cat - if changed please amend these as well.

@edelarua edelarua self-assigned this Feb 23, 2024
@edelarua edelarua added the sme label Feb 23, 2024
edelarua added a commit that referenced this issue Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants