Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration tests #743

Closed
Melkiades opened this issue Nov 14, 2022 · 6 comments · Fixed by #750
Closed

Fix integration tests #743

Melkiades opened this issue Nov 14, 2022 · 6 comments · Fixed by #750
Assignees
Labels
automation bug Something isn't working sme

Comments

@Melkiades
Copy link
Contributor

Melkiades commented Nov 14, 2022

We get the following to fix:

  ✖ | 3      31 | summarize_glm_count [0.5s]                                      
  ────────────────────────────────────────────────────────────────────────────────
  Failure (test-summarize_glm_count.R:60:3): h_glm_poisson emmeans-fit works with healthy input
  mat1$statistic not equal to expected$statistic.
  target is NULL, current is numeric
  
  Failure (test-summarize_glm_count.R:157:3): h_glm_quasipoisson emmeans-fit works with healthy input
  mat1$statistic not equal to expected$statistic.
  target is NULL, current is numeric
  
  Failure (test-summarize_glm_count.R:240:3): h_glm_count emmeans-fit works with healthy input
  mat1$statistic not equal to expected$statistic.
  target is NULL, current is numeric
  ────────────────────────────────────────────────────────────────────────────────
  ✖ |  14 1     | coxph [0.3 s]                                                   
  ────────────────────────────────────────────────────────────────────────────────
  Failure (test-coxph.R:59:3): try_car_anova works correctly
  result$warn_text not identical to NULL.
  Types not compatible: character is not NULL
@Melkiades Melkiades added bug Something isn't working automation labels Nov 14, 2022
@Melkiades Melkiades self-assigned this Nov 14, 2022
@ayogasekaram ayogasekaram self-assigned this Nov 14, 2022
@Melkiades Melkiades added the sme label Nov 14, 2022
@Melkiades
Copy link
Contributor Author

I cannot reproduce this locally, unfortunately. Could it be a version problem? Tests are run under the following version:

* using R version 4.1.1 (2021-08-10)
* using platform: x86_64-pc-linux-gnu (64-bit)
* using session charset: UTF-8
* checking for file ‘tern/DESCRIPTION’ ... OK
* this is package ‘tern’ version ‘0.7.10.9009’

@ayogasekaram
Copy link
Contributor

I also cannot reproduce these failures locally.
image

@Melkiades
Copy link
Contributor Author

@arkadiuszbeer do you have any idea why this could happen only on the integration side of things?

@arkadiuszbeer
Copy link
Contributor

@Melkiades I am on it.
I am testing on bee docker image, but now it is stuck on Running ‘testthat.R’ for 2 hours - I am also investigating it.

@arkadiuszbeer
Copy link
Contributor

I was able to reproduce this error on bee server.

x | 3      31 | summarize_glm_count [0.7s]                                      
────────────────────────────────────────────────────────────────────────────────
Failure (test-summarize_glm_count.R:60:3): h_glm_poisson emmeans-fit works with healthy input
mat1$statistic not equal to expected$statistic.
target is NULL, current is numeric

Failure (test-summarize_glm_count.R:157:3): h_glm_quasipoisson emmeans-fit works with healthy input
mat1$statistic not equal to expected$statistic.
target is NULL, current is numeric

Failure (test-summarize_glm_count.R:240:3): h_glm_count emmeans-fit works with healthy input
mat1$statistic not equal to expected$statistic.
target is NULL, current is numeric
────────────────────────────────────────────────────────────────────────────────                                                                             
✓ |        18 | summarize_num_patients [0.6s]                                   

@ayogasekaram ayogasekaram removed their assignment Nov 21, 2022
@Melkiades
Copy link
Contributor Author

@Melkiades Melkiades added blocked and removed blocked labels Nov 21, 2022
@Melkiades Melkiades mentioned this issue Nov 22, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation bug Something isn't working sme
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants