-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests #750
Fix tests #750
Conversation
Code Coverage Summary
Diff against main
Results for commit: a272067 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Thank you @Melkiades for looking into this. I installed the latest version of broom and re-ran the tests but I am still getting the original column headers. regardless, if the values are the same but the column name is different, I believe we're testing the same stats and it should be good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Thanks @Melkiades
There were two different bugs here.
broom::tidy
behaves differently for objectemmGrid
between version0.7.x
and1.0.x
survival
was missing as a reference in many tests. This has to be fixed generally too. In this case, in particular, it was generating a different output depending on the version. Please note that if I explicitly usesurvival::strata
instead of juststrata
, the strata results are not dropped and the final values are quite different. @ayogasekaram @edelarua could you check what is the expected behavior here?Fixes #743