-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
687 fix from formatters na str@main #690
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @Melkiades
@Melkiades I'm not sure why these two tests are failing since you didn't update them. They don't failing when I run them, are they failing for you? |
They do fail locally for me. I fixed both here, and I think it was due to an external update of the function |
Code Coverage Summary
Diff against main
Results for commit: 6e8e93f Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Pull Request
Fixes #687