Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

692 Fix count_abnormal_by_worst_grade PARAM bug #693

Merged
merged 2 commits into from
Aug 30, 2022

Conversation

edelarua
Copy link
Contributor

@edelarua edelarua added the sme label Aug 29, 2022
@github-actions
Copy link
Contributor

badge

Code Coverage Summary

Filename                                   Stmts    Miss  Cover    Missing
---------------------------------------  -------  ------  -------  ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
R/abnormal_by_baseline.R                      63       0  100.00%
R/abnormal_by_marked.R                        52       5  90.38%   124-128
R/abnormal_by_worst_grade_worsen.R           113       3  97.35%   206-208
R/abnormal_by_worst_grade.R                   37       0  100.00%
R/abnormal.R                                  40       0  100.00%
R/combination_function.R                       9       0  100.00%
R/compare_variables.R                        138       3  97.83%   135, 247, 266
R/control_incidence_rate.R                    10       0  100.00%
R/control_logistic.R                           7       0  100.00%
R/control_step.R                              23       1  95.65%   58
R/control_survival.R                          15       0  100.00%
R/count_cumulative.R                          47       1  97.87%   52
R/count_missed_doses.R                        31       0  100.00%
R/count_occurrences_by_grade.R                79       1  98.73%   148
R/count_occurrences.R                         61       1  98.36%   89
R/count_patients_events_in_cols.R             67       0  100.00%
R/count_patients_with_event.R                 72      22  69.44%   208-231
R/count_values.R                              24       0  100.00%
R/cox_regression_inter.R                     142       0  100.00%
R/cox_regression.R                           318       0  100.00%
R/coxph.R                                    313      91  70.93%   19-43, 151, 158, 178, 181, 225-239, 242-246, 536-540, 585, 598, 607, 616, 623-635, 693-749
R/d_pkparam.R                                405       0  100.00%
R/decorate_grob.R                            167     167  0.00%    158-517
R/deprec-nest_colors.R                         5       5  0.00%    55-59
R/desctools_binom_diff.R                     668     415  37.87%   57, 62, 84-94, 97-98, 119-134, 137-176, 179-186, 196-244, 247-258, 261-273, 276-289, 297, 299, 319, 323, 327, 331, 367, 383, 386, 389, 392, 399, 414-416, 419-422, 432-439, 442-449, 452-453, 455-458, 460-461, 463-464, 468-474, 476, 478-483, 485-486, 490-491, 493-494, 496-499, 502-503, 505-506, 508-509, 514-515, 518-521, 524-529, 532-550, 553-564, 566-581, 585-601, 603-607, 611-643, 645-673, 677-695, 697-703, 712, 714, 727, 731
R/df_explicit_na.R                            30       0  100.00%
R/estimate_multinomial_rsp.R                  47       1  97.87%   53
R/estimate_proportion.R                       97       1  98.97%   264
R/fit_rsp_step.R                              36       7  80.56%   104-110
R/fit_survival_step.R                         36       7  80.56%   85-91
R/formats.R                                   88       1  98.86%   66
R/g_forest.R                                 446      46  89.69%   171, 199, 228, 251-252, 256-257, 325, 338, 342-343, 348-349, 362, 378, 425, 456, 532, 541, 613-633, 636, 647, 704, 707, 833-855, 897-898
R/g_lineplot.R                               192     172  10.42%   163-412, 457, 465, 503-510
R/g_step.R                                    59      30  49.15%   83-120
R/g_waterfall.R                               47      47  0.00%    83-145
R/h_adsl_adlb_merge_using_worst_flag.R        74       0  100.00%
R/h_biomarkers_subgroups.R                    38       0  100.00%
R/h_map_for_count_abnormal.R                  54       0  100.00%
R/h_pkparam_sort.R                            15       0  100.00%
R/h_response_biomarkers_subgroups.R           74       0  100.00%
R/h_response_subgroups.R                     171      12  92.98%   248-261
R/h_stack_by_baskets.R                        65       2  96.92%   96, 143
R/h_step.R                                   180       0  100.00%
R/h_survival_biomarkers_subgroups.R           78       0  100.00%
R/h_survival_duration_subgroups.R            200      12  94.00%   254-266
R/incidence_rate.R                            93       7  92.47%   69-76
R/individual_patient_plot.R                  140     140  0.00%    39-276
R/kaplan_meier_plot.R                        530     107  79.81%   252-256, 308-322, 373-382, 440, 516-522, 579-581, 607-608, 610-612, 620-622, 648, 653-656, 822-843, 1019, 1242-1274
R/logistic_regression.R                      569       3  99.47%   279-280, 347
R/missing_data.R                              20       3  85.00%   29, 61, 71
R/odds_ratio.R                               106      16  84.91%   181-199
R/prop_diff_test.R                            87       0  100.00%
R/prop_diff.R                                177      45  74.58%   56-63, 109, 189, 252, 336-377
R/prune_occurrences.R                         57       0  100.00%
R/response_biomarkers_subgroups.R             59       0  100.00%
R/response_subgroups.R                       164       0  100.00%
R/rtables_access.R                            21       0  100.00%
R/score_occurrences.R                         20       1  95.00%   113
R/split_cols_by_groups.R                      49       0  100.00%
R/stat.R                                      47       0  100.00%
R/summarize_ancova.R                          94      14  85.11%   152-159, 168-174, 194
R/summarize_change.R                          27       0  100.00%
R/summarize_colvars.R                          6       0  100.00%
R/summarize_num_patients.R                    47       3  93.62%   93-95
R/summarize_patients_exposure_in_cols.R       46       0  100.00%
R/summarize_variables_in_cols.R               64      22  65.62%   35, 37, 65, 67, 92-132
R/summarize_variables.R                      212      19  91.04%   85-102, 477
R/survival_biomarkers_subgroups.R             59       0  100.00%
R/survival_coxph_pairwise.R                   73       9  87.67%   68-76
R/survival_duration_subgroups.R              171       0  100.00%
R/survival_time.R                             47       0  100.00%
R/survival_timepoint.R                       114       7  93.86%   146-152
R/utils_checkmate.R                           68       0  100.00%
R/utils_factor.R                              95       1  98.95%   93
R/utils_grid.R                               111     111  0.00%    39-266
R/utils_rtables.R                             74       2  97.30%   317-318
R/utils.R                                    137      31  77.37%   99-149
R/wrap_text.R                                 64      64  0.00%    30-105
TOTAL                                       8581    1658  80.68%

Diff against main

Filename    Stmts    Miss    Cover
----------  -------  ------  -------
TOTAL       -        -       -

Results for commit: 0bd9d95

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

Unit Tests Summary

       1 files     115 suites   4m 31s ⏱️
   780 tests    780 ✔️ 0 💤 0
1 179 runs  1 179 ✔️ 0 💤 0

Results for commit 3ff5f40.

Copy link
Contributor

@JiaLiu0001 JiaLiu0001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @edelarua The PR looks great.

@edelarua edelarua merged commit 7c28087 into main Aug 30, 2022
@edelarua edelarua deleted the 692_fix_count_abnormal_by_worst_grade_param_bug@main branch August 30, 2022 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: count_abnormal_by_worst_grade returns error when there's only 1 unique PARAM
2 participants